Skip to content

Add php version to valet links command#1

Open
damsfx wants to merge 1 commit intoiamroi:masterfrom
damsfx:patch-1
Open

Add php version to valet links command#1
damsfx wants to merge 1 commit intoiamroi:masterfrom
damsfx:patch-1

Conversation

@damsfx
Copy link
Copy Markdown

@damsfx damsfx commented Jun 16, 2022 

> valet links
+-------+-----+--------+--------------------+-----------------+
| Site  | SSL | Php    | URL                | Path            |
+-------+-----+--------+--------------------+-----------------+
| site1 |     | 8.0.17 | http://site1.local | D:\_Sites\site1 |
| site2 |     |        | http://site2.local | D:\_Sites\site2 |
+-------+-----+--------+--------------------+-----------------+

@iamroi
Copy link
Copy Markdown
Owner

iamroi commented Jun 22, 2022

Thanks @damsfx I'll have a look at this this weekend

@damsfx damsfx mentioned this pull request Jun 22, 2022
Open
@yCodeTech
Copy link
Copy Markdown

yCodeTech commented May 3, 2023 •
edited
Loading

When specifying a site to use a specific version with valet use "8.1.8" --site="my-project", is there any way to check which php version those isolated sites are using?

Edit

Nevermind, I've used the code added in this pr to also add the php version to the valet parked command, so while outputting every site available to valet, it will also output the isolated php version (coloured green for emphasis) if configured, otherwise it will output the default version. At this time, I'm not gonna bother doing a pr for it, but my patch can be found here.

> valet parked
+-------+-----+-------------------+---------------------+-----------------+
| Site  | SSL | PHP               | URL                 | Path            |
+-------+-----+-------------------+---------------------+-----------------+
| site1 |     | 8.0.17 (default)  | http://site1.local/ | D:\_Sites\site1 |
| site2 |     | 7.4.33 (isolated) | http://site2.local/ | D:\_Sites\site2 |
| site3 |     | 8.0.17 (default)  | http://site3.local/ | D:\_Sites\site3 |
| site4 |     | 8.0.17 (default)  | http://site4.local/ | D:\_Sites\site4 |
+-------+-----+-------------------+---------------------+-----------------+

Also added a new command valet php:which to determine which version the current working directory is using.
Ouput: This site site1 is using PHP 8.0.17 (default)

Edit (July 2023)

The aforementioned patch has since been deleted in favour of my 3.0 version of Valet, Laravel Valet Windows 3.

@damsfx
Copy link
Copy Markdown
Author

damsfx commented Oct 19, 2023

@yCodeTech I've just discovered this post and your fork ... It's just great. 😍
I think this project is dead ... but your fork is top notch.

damsfx pushed a commit to damsfx/valet-windows that referenced this pull request Feb 14, 2024
@yCodeTech
Merge pull request iamroi#1 from yCodeTech/patch-2
3abe8d2 
Patch 2 - Feature: add PHP version to the command links and parked outputs and new command php:which
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damsfx @iamroi @yCodeTech