fix(snapshot): return empty array from getBranches in snapshot mode#1982
Merged
fix(snapshot): return empty array from getBranches in snapshot mode#1982
Conversation
getBranches called ensureGitRepo which throws when the workspace is in snapshot mode. The renderer calls getBranches regardless of mode, causing an unhandled promise rejection (ELECTRON-G8, 5 events, 2 on v1.9.4). Return [] instead of throwing for non-git-repo workspaces.
Contributor
Code Review：fix(snapshot): return empty array from getBranches in snapshot mode (#1982)变更概述本 PR 修复了 方案评估结论：✅ 方案合理 修改将 问题清单✅ 未发现明显问题，代码质量良好，建议批准合并。 汇总无问题。 结论
本报告由本地 CONCLUSION: APPROVED |
Contributor
|
✅ 已自动 review，无阻塞性问题，正在触发自动合并。 |
piorpua
added
bot:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getBranchescalledensureGitRepowhich throws when the workspace is in snapshot mode, causing an unhandled promise rejection (Sentry ELECTRON-G8, 5 events, 2 on v1.9.4)getBranchesto check snapshot state inline and return[]for non-git-repo workspaces instead of throwinggetBranchesin both snapshot and uninitialised workspace scenariosTest plan
WorkspaceSnapshotService.test.ts— 30/30 passing)