fix(platform): add getLogsDir fallback to inline platform services#1980
Merged
fix(platform): add getLogsDir fallback to inline platform services#1980
Conversation
The inline auto-registered platform services in index.ts were missing
the try-catch fallback for app.getPath('logs') that was added to
ElectronPlatformServices in PR #1967. When code runs before
registerPlatformServices() is called, the inline path throws on systems
where app.getPath('logs') fails, causing 'Failed to get logs path'
errors through the adapter bridge IPC.
Contributor
Code Review：fix(platform): add getLogsDir fallback to inline platform services (#1980)变更概述本 PR 为 方案评估结论：✅ 方案合理 修复直接针对 Sentry 上报的 ELECTRON-GW 错误，方案与 问题清单✅ 未发现明显问题，代码质量良好。 汇总
结论✅ 批准合并 — 改动精确、与现有模式一致、有回归测试覆盖，无阻塞性问题。 本报告由本地 CONCLUSION: APPROVED |
Contributor
|
✅ 已自动 review，无阻塞性问题，正在触发自动合并。 |
piorpua
added
bot:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.getPath('logs')in the inline auto-registered platform services (src/common/platform/index.ts), matching the existing fallback inElectronPlatformServicesregisterPlatformServices()is called; without the fallback,app.getPath('logs')throws on some systems, causing "Failed to get 'logs' path" errors through the adapter bridge IPCFixes Sentry issue ELECTRON-GW (2 events).
Test plan
inlinePlatformServices.test.tsverifies the try-catch pattern exists inindex.tstsc --noEmitpassesbun run lint— 0 errors