Skip to content

fix(mobile): add SafeArea support and update app icon#1926

Merged
piorpua merged 1 commit intomainfrom
fix/mobile-safearea-and-icon
Mar 30, 2026
Merged

fix(mobile): add SafeArea support and update app icon#1926
piorpua merged 1 commit intomainfrom
fix/mobile-safearea-and-icon

Conversation

@kaizhou-lab
Copy link
Copy Markdown
Collaborator

Summary

  • Add SafeAreaProvider at root layout for proper safe area context
  • Wrap connect screen views with SafeAreaView for notch/home indicator support
  • Add theme-matching background color to tabs SafeAreaView
  • Add bottom inset padding to file-preview scroll content
  • Replace placeholder icon with AionUi logo
  • Add Android adaptive icon foregroundImage config

Closes #1925

- Add SafeAreaProvider at root layout for proper safe area context
- Wrap connect screen views with SafeAreaView for notch/home indicator
- Add background color to tabs SafeAreaView matching theme
- Add bottom inset padding to file-preview scroll content
- Replace placeholder icon with AionUi logo
- Add Android adaptive icon foregroundImage config
@piorpua piorpua added the bot:reviewing Review in progress (mutex) label Mar 30, 2026
@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 30, 2026

Code Review:fix(mobile): add SafeArea support and update app icon (#1926)

变更概述

本 PR 为移动端补全了 SafeArea 支持:在根布局添加 SafeAreaProvider,将各屏幕的 View 容器替换为 SafeAreaView,并通过 useSafeAreaInsets 为相机扫描页和文件预览页的滚动内容补充底部 padding。同时更新了 App 图标,并为 Android 自适应图标补充了 foregroundImage 配置。


方案评估

结论:✅ 方案合理

SafeArea 修复采用了 react-native-safe-area-context 的标准模式(SafeAreaProvider + SafeAreaView / useSafeAreaInsets),与项目已有用法保持一致。根布局统一添加 SafeAreaProvider 是正确的做法。相机扫描页对全屏 camera 保持裸 View、仅对底部按钮动态计算 insets.bottom,属于合理的设计取舍。


问题清单

🔵 LOW — _layout.tsxconnect.tsx 中 JSX 缩进不一致

文件mobile/app/_layout.tsx,第 28–56 行;mobile/app/connect.tsx,第 129–166 行

问题说明:子元素缩进未跟随父元素,JSX 层级关系不直观,后续维护时容易误判结构。

修复建议:运行 bun run format 让 Oxfmt 自动修正,无需手动修改。


汇总

# 严重级别 文件 问题
1 🔵 LOW app/_layout.tsx:28-56app/connect.tsx:129-166 JSX 缩进不一致,可通过 format 自动修复

结论

批准合并 — 无阻塞性问题,SafeArea 修复方案正确,仅有一处可自动修复的格式问题。


本报告由本地 pr-review skill 生成,包含完整项目上下文,无截断限制。

CONCLUSION: APPROVED
IS_CRITICAL_PATH: false
PR_NUMBER: 1926

@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 30, 2026

✅ 已自动 review,无阻塞性问题,正在触发自动合并。

@piorpua piorpua merged commit 505d245 into main Mar 30, 2026
17 checks passed
@piorpua piorpua deleted the fix/mobile-safearea-and-icon branch March 30, 2026 10:35
@piorpua piorpua added bot:done Auto-merged by bot and removed bot:reviewing Review in progress (mutex) labels Mar 30, 2026
wuhao1477 added a commit to wuhao1477/AionUi that referenced this pull request Mar 30, 2026
* 'main' of github.com:wuhao1477/AionUi: (40 commits)
  fix(agents): prevent unhandled promise rejection in bootstrap initialization (iOfficeAI#1933)
  fix(gemini): restore context after stopping a reply (iOfficeAI#1932)
  fix(codex): reject start promise immediately on process exit during startup (iOfficeAI#1929)
  fix(conversation): sync renamed titles with detail view (iOfficeAI#1927)
  fix(paste): deduplicate filenames when pasting multiple images simultaneously
  fix(mobile): add SafeArea support and update app icon (iOfficeAI#1926)
  fix(database): guard against undefined params in databaseBridge providers (iOfficeAI#1924)
  fix(conversation): validate type field before creating conversation (iOfficeAI#1921)
  fix(docs): restore wechat_group_5.png reference to wx-5.png in readme
  fix(snapshot): add maxBuffer to git add/commit exec calls (iOfficeAI#1914)
  refactor(acp): consolidate AGENT_SKILLS_DIRS into ACP_BACKENDS_ALL (iOfficeAI#1913)
  fix(gemini): guard against EACCES in workspace realpath during init (ELECTRON-BM) (iOfficeAI#1912)
  fix(channels): send raw QR ticket instead of page URL in WeChat WebUI login SSE (iOfficeAI#1910)
  .md format
  chore(pr-automation): fix missed sleep 5 in comment to sleep 10
  chore(pr-automation): increase auto-merge retry delay to 10s
  chore(pr-automation): add 5s retry for transient GitHub mergeStateStatus UNKNOWN
  fix(docs): remove trailing whitespace in OfficeCLI readmes
  chore(pr-automation): verify auto-merge success before labeling bot:done
  fix(snapshot): guard against non-existent workspace in WorkspaceSnapshotService.init (iOfficeAI#1906)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:done Auto-merged by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mobile): add SafeArea support and update app icon

2 participants