fix(mobile): add SafeArea support and update app icon#1926
Merged
Conversation
- Add SafeAreaProvider at root layout for proper safe area context - Wrap connect screen views with SafeAreaView for notch/home indicator - Add background color to tabs SafeAreaView matching theme - Add bottom inset padding to file-preview scroll content - Replace placeholder icon with AionUi logo - Add Android adaptive icon foregroundImage config
Contributor
Code Review:fix(mobile): add SafeArea support and update app icon (#1926)变更概述本 PR 为移动端补全了 SafeArea 支持:在根布局添加 方案评估结论:✅ 方案合理 SafeArea 修复采用了 问题清单🔵 LOW —
|
| # | 严重级别 | 文件 | 问题 |
|---|---|---|---|
| 1 | 🔵 LOW | app/_layout.tsx:28-56,app/connect.tsx:129-166 |
JSX 缩进不一致,可通过 format 自动修复 |
结论
✅ 批准合并 — 无阻塞性问题,SafeArea 修复方案正确,仅有一处可自动修复的格式问题。
本报告由本地 pr-review skill 生成,包含完整项目上下文,无截断限制。
CONCLUSION: APPROVED
IS_CRITICAL_PATH: false
PR_NUMBER: 1926
Contributor
|
✅ 已自动 review,无阻塞性问题,正在触发自动合并。 |
wuhao1477
added a commit
to wuhao1477/AionUi
that referenced
this pull request
Mar 30, 2026
* 'main' of github.com:wuhao1477/AionUi: (40 commits) fix(agents): prevent unhandled promise rejection in bootstrap initialization (iOfficeAI#1933) fix(gemini): restore context after stopping a reply (iOfficeAI#1932) fix(codex): reject start promise immediately on process exit during startup (iOfficeAI#1929) fix(conversation): sync renamed titles with detail view (iOfficeAI#1927) fix(paste): deduplicate filenames when pasting multiple images simultaneously fix(mobile): add SafeArea support and update app icon (iOfficeAI#1926) fix(database): guard against undefined params in databaseBridge providers (iOfficeAI#1924) fix(conversation): validate type field before creating conversation (iOfficeAI#1921) fix(docs): restore wechat_group_5.png reference to wx-5.png in readme fix(snapshot): add maxBuffer to git add/commit exec calls (iOfficeAI#1914) refactor(acp): consolidate AGENT_SKILLS_DIRS into ACP_BACKENDS_ALL (iOfficeAI#1913) fix(gemini): guard against EACCES in workspace realpath during init (ELECTRON-BM) (iOfficeAI#1912) fix(channels): send raw QR ticket instead of page URL in WeChat WebUI login SSE (iOfficeAI#1910) .md format chore(pr-automation): fix missed sleep 5 in comment to sleep 10 chore(pr-automation): increase auto-merge retry delay to 10s chore(pr-automation): add 5s retry for transient GitHub mergeStateStatus UNKNOWN fix(docs): remove trailing whitespace in OfficeCLI readmes chore(pr-automation): verify auto-merge success before labeling bot:done fix(snapshot): guard against non-existent workspace in WorkspaceSnapshotService.init (iOfficeAI#1906) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SafeAreaProviderat root layout for proper safe area contextSafeAreaViewfor notch/home indicator supportSafeAreaViewforegroundImageconfigCloses #1925