fix(database): guard against undefined params in databaseBridge providers#1924
Merged
fix(database): guard against undefined params in databaseBridge providers#1924
Conversation
…ders
When the WebSocket sends a message with no data payload, the provider
callbacks in databaseBridge receive undefined as their parameter. Destructuring
undefined throws TypeError: Cannot read properties of undefined.
Accept params as a variable first, then use nullish coalescing (?? {}) before
destructuring to safely handle undefined payloads.
Fixes ELECTRON-FN
Contributor
Code Review：fix(database): guard against undefined params in databaseBridge providers (#1924)变更概述此 PR 修复 Sentry 线上 Bug（ELECTRON-FN）：WebSocket 消息携带 方案评估结论：✅ 方案合理 三处修复模式一致、最小化改动： 问题清单未发现需要报告的问题。代码逻辑正确，边界处理合理，测试覆盖了全部三个 provider 的 汇总无问题。 结论✅ 批准合并 — 无阻塞性问题，修复精准，测试完备，CI 全部通过。 本报告由本地 CONCLUSION: APPROVED |
Contributor
|
✅ 已自动 review，无阻塞性问题，正在触发自动合并。 |
piorpua
added
bot:done
wuhao1477
added a commit
to wuhao1477/AionUi
that referenced
this pull request
Mar 30, 2026
* 'main' of github.com:wuhao1477/AionUi: (40 commits) fix(agents): prevent unhandled promise rejection in bootstrap initialization (iOfficeAI#1933) fix(gemini): restore context after stopping a reply (iOfficeAI#1932) fix(codex): reject start promise immediately on process exit during startup (iOfficeAI#1929) fix(conversation): sync renamed titles with detail view (iOfficeAI#1927) fix(paste): deduplicate filenames when pasting multiple images simultaneously fix(mobile): add SafeArea support and update app icon (iOfficeAI#1926) fix(database): guard against undefined params in databaseBridge providers (iOfficeAI#1924) fix(conversation): validate type field before creating conversation (iOfficeAI#1921) fix(docs): restore wechat_group_5.png reference to wx-5.png in readme fix(snapshot): add maxBuffer to git add/commit exec calls (iOfficeAI#1914) refactor(acp): consolidate AGENT_SKILLS_DIRS into ACP_BACKENDS_ALL (iOfficeAI#1913) fix(gemini): guard against EACCES in workspace realpath during init (ELECTRON-BM) (iOfficeAI#1912) fix(channels): send raw QR ticket instead of page URL in WeChat WebUI login SSE (iOfficeAI#1910) .md format chore(pr-automation): fix missed sleep 5 in comment to sleep 10 chore(pr-automation): increase auto-merge retry delay to 10s chore(pr-automation): add 5s retry for transient GitHub mergeStateStatus UNKNOWN fix(docs): remove trailing whitespace in OfficeCLI readmes chore(pr-automation): verify auto-merge success before labeling bot:done fix(snapshot): guard against non-existent workspace in WorkspaceSnapshotService.init (iOfficeAI#1906) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ipcBridge.database.*provider callbacks indatabaseBridge.tsagainstundefinedparameters by accepting params as a variable and using nullish coalescing (?? {}) before destructuringundefinedparams without throwingSentry Issue
ELECTRON-FN —
TypeError: Cannot read properties of undefined (reading 'page')databaseBridge.ts:26—getUserConversationsproviderundefineddata payload; destructuringundefinedthrows TypeErrorTest plan
undefinedparamsbunx tsc --noEmitpassesbun run lint:fix— 0 errorsbun run format— clean