Skip to content

fix(guid): show upload progress on new chat#1905

Merged
piorpua merged 1 commit intoiOfficeAI:mainfrom
JerryLiu369:fix/guid-upload-progress
Mar 30, 2026
Merged

fix(guid): show upload progress on new chat#1905
piorpua merged 1 commit intoiOfficeAI:mainfrom
JerryLiu369:fix/guid-upload-progress

Conversation

@JerryLiu369
Copy link
Copy Markdown
Member

Summary

  • render the existing upload progress bar on the Guid new-chat page
  • reuse the current sendbox-scoped upload state so dragged or pasted files show progress while uploading

Testing

  • NODE_OPTIONS=--max-old-space-size=4096 bun run build:renderer:web

Notes

  • this only fixes missing progress visibility on the Guid page
  • it does not change the existing upload-state scoping behavior across different sendboxes

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@piorpua piorpua added the bot:reviewing Review in progress (mutex) label Mar 30, 2026
@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 30, 2026

Code Review:fix(guid): show upload progress on new chat (#1905)

变更概述

本 PR 在 Guid 新对话页面的输入卡片(GuidInputCard.tsx)中添加了上传进度条组件 UploadProgressBar,使拖拽或粘贴文件时能正确显示上传进度。改动涉及单个 renderer 组件文件,范围极小。


方案评估

结论:✅ 方案合理

直接复用已有的 UploadProgressBar 组件,并与 sendbox.tsx(line 734)保持完全一致的使用方式(source='sendbox')。方案没有引入任何新的抽象或依赖,是最小化修复。


问题清单

未发现任何由本次改动引入的问题。

备注:lint 警告 dragHandlers: Record<string, any>(第 35 行)为历史遗留,与本次 PR 无关,不作为阻塞点。


汇总

无问题。

结论

批准合并 — 改动正确、简洁,完全复用现有模式,无阻塞性问题。


本报告由本地 pr-review skill 生成,包含完整项目上下文,无截断限制。

@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 30, 2026

✅ 已自动 review,无阻塞性问题,正在触发自动合并。

@piorpua piorpua merged commit 4559c23 into iOfficeAI:main Mar 30, 2026
14 checks passed
@piorpua piorpua added bot:done Auto-merged by bot and removed bot:reviewing Review in progress (mutex) labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:done Auto-merged by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants