fix(webui): use public directory icon for favicon#1857
Merged
Conversation
The favicon <link> in index.html used a relative path ../../resources/icon.png that escapes the Express static root in WebUI mode. Changed to ./pwa/icon-192.png which exists in the public/ directory and resolves correctly in both Electron (file://) and WebUI (Express static serving). Closes #1178
Contributor
Code Review：fix(webui): use public directory icon for favicon (#1857)变更概述本 PR 修复了 WebUI 模式下 favicon 图标无法显示的问题。 方案评估结论：✅ 方案合理 修复精准定位了根本原因（路径逃出 Express 静态根目录），使用 问题清单未发现任何问题。 汇总无问题。 结论✅ 批准合并 — 修复正确，测试充分，代码干净，无阻塞性问题。 本报告由本地 |
Contributor
|
✅ 已自动 review，无阻塞性问题，正在触发自动合并。 |
piorpua
added
bot:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<link>inindex.htmlused../../resources/icon.pngwhich works in Electron (file://) but resolves outside the Express static root in WebUI mode./pwa/icon-192.pngwhich exists inpublic/and works in both Electron and WebUI contextsRelated Issues
Closes #1178
Test Plan