feat(conversation): implement command queue workflow by Ericwong5021 · Pull Request #1856 · iOfficeAI/AionUi

Ericwong5021 · 2026-03-28T13:23:05Z

Summary

Add a full command queue workflow for conversation sessions, so newly submitted commands can be queued instead of being sent immediately while the current turn is still running
Introduce a compact Codex-style queue panel with single-line task cards, drag-to-reorder, inline edit, remove, and clear interactions
Integrate queue execution control into Codex, ACP, Gemini, Nanobot, and OpenClaw send flows, so queued commands follow a consistent renderer-side scheduling model across supported conversation platforms
Harden queue execution around stop/recovery, dequeue timing, persistence restore, invalid payload filtering, and drag interaction edge cases to prevent duplicate dispatch, skipped commands, or stuck queue state
Remove deprecated queue controls, obsolete pause/cancel paths, and related i18n leftovers so the final implementation matches the current product behavior and keeps the branch clean

Scope

Add shared queue state management, enqueue/dequeue gating, persistence normalization, and execution recovery in useConversationCommandQueue
Add a dedicated CommandQueuePanel for queue rendering and user interaction
Update sendbox.tsx and platform-specific send boxes so queue behavior is applied consistently in actual conversation send flows
Update queue-related conversation locale resources and regenerated i18n typings
Add queue logic, DOM interaction, drag behavior, platform integration, and regression coverage for the new workflow

Functional Boundary

Included in this PR:
- Queue commands while the current conversation task is still running
- Automatically release queued commands one-by-one when the conversation returns to idle
- Edit pending queued commands before execution
- Remove a single queued command or clear remaining queued commands
- Drag-sort pending queued commands in the queue panel
- Recover correctly when the user manually stops the current output
- Restore valid queued items from persisted state after reload
Not included in this PR:
- Cross-conversation shared queues
- Parallel execution of multiple queued commands
- Queue scheduling across different assistant sessions or windows
- A persistent pause/resume queue mode
- Any backend-side global scheduler outside the current renderer conversation flow

Impacted Areas

src/renderer/pages/conversation/platforms/useConversationCommandQueue.ts
src/renderer/components/chat/CommandQueuePanel.tsx
src/renderer/components/chat/sendbox.tsx
src/renderer/pages/conversation/platforms/codex/CodexSendBox.tsx
src/renderer/pages/conversation/platforms/acp/AcpSendBox.tsx
src/renderer/pages/conversation/platforms/gemini/GeminiSendBox.tsx
src/renderer/pages/conversation/platforms/nanobot/NanobotSendBox.tsx
src/renderer/pages/conversation/platforms/openclaw/OpenClawSendBox.tsx
src/renderer/pages/conversation/Messages/hooks.ts
src/renderer/services/i18n/locales/*/conversation.json
tests/unit/renderer/conversationCommandQueue.test.ts
tests/unit/renderer/conversationCommandQueue.dom.test.tsx
tests/unit/renderer/conversationCommandQueue.drag.dom.test.tsx
tests/unit/sendboxQueue.dom.test.tsx
tests/unit/renderer/platformSendBoxes.dom.test.tsx
tests/unit/renderer/useGeminiInitialMessage.dom.test.tsx
tests/unit/renderer/messageHooks.dom.test.tsx

Test plan

piorpua · 2026-03-29T09:49:19Z

合并冲突（无法自动解决）

本 PR 与目标分支存在冲突，自动 rebase 未能干净解决。请手动 rebase 后重新 push：

git fetch origin
git rebase origin/main
# 解决冲突后
git push --force-with-lease

…d validation - Added editing functionality to the conversation command queue, allowing users to edit queued commands. - Implemented validation to prevent empty command inputs and deduplicate files during updates. - Introduced new i18n strings for editing actions in the zh-TW locale. - Created a new utility function `assertBridgeSuccess` to handle bridge response validation. - Added unit tests for the new editing features and bridge success assertions. - Developed comprehensive DOM tests for the SendBox component, including interaction behaviors and mobile focus handling.

…ity in command queue components

sentry · 2026-03-29T15:53:16Z

Codecov Report

❌ Patch coverage is 82.50460% with 95 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...versation/platforms/useConversationCommandQueue.ts	90.51%	12 Missing and 12 partials ⚠️
src/renderer/components/chat/CommandQueuePanel.tsx	81.19%	13 Missing and 9 partials ⚠️
...er/pages/conversation/platforms/acp/AcpSendBox.tsx	59.37%	12 Missing and 1 partial ⚠️
...onversation/platforms/openclaw/OpenClawSendBox.tsx	66.66%	6 Missing and 6 partials ⚠️
...es/conversation/platforms/gemini/GeminiSendBox.tsx	65.62%	9 Missing and 2 partials ⚠️
...ages/conversation/platforms/codex/CodexSendBox.tsx	73.07%	7 Missing ⚠️
.../conversation/platforms/nanobot/NanobotSendBox.tsx	76.00%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

piorpua · 2026-03-30T14:28:28Z

Code Review：feat(conversation): implement command queue workflow (#1856)

变更概述

此 PR 为所有支持平台（Codex、ACP、Gemini、Nanobot、OpenClaw）实现了完整的对话命令队列工作流，新增 useConversationCommandQueue 核心 Hook 和 CommandQueuePanel 展示组件，支持排队、拖拽排序、编辑、删除和自动执行。同时增加了 assertBridgeSuccess 工具、更新 i18n 资源，并补充了覆盖主要场景的单元测试和 DOM 测试。

方案评估

结论：✅ 方案合理

方案通过 renderer-side SWR + sessionStorage 实现轻量持久化，与项目架构保持一致，没有跨进程通信的额外复杂度。执行控制采用 ref 跟踪 waiting 状态并结合 executionGateVersion 触发重试的设计有效解决了 stop/recovery 的竞态问题。CommandQueuePanel 组件职责单一，dnd-kit 集成规范。整体方案没有明显设计盲点。

问题清单

🟠 HIGH — sendbox.tsx：isBtwInput 声明未使用

文件：src/renderer/components/chat/sendbox.tsx，第 241 行

问题代码：

const isBtwInput = enableBtw && btwQuestion !== null;

问题说明：此 PR 删除了 isBtwInput 在 JSX 中的引用（原为 isLoading || (loading && !isBtwInput) 的条件判断），但未同步删除变量声明。oxlint no-unused-vars 已标记此警告。

修复建议：删除第 241 行的 isBtwInput 声明。

🔵 LOW — AcpSendBox.tsx：TMessage 导入未使用（存量问题）

文件：src/renderer/pages/conversation/platforms/acp/AcpSendBox.tsx，第 3 行

问题代码：

import type { TMessage } from '@/common/chat/chatLib';

问题说明：TMessage 在此文件中未被引用，oxlint 已标记。这是 main 分支上的存量问题，本 PR 修改了此文件但未清理。

修复建议：删除该导入行。

汇总

#	严重级别	文件	问题
1	🟠 HIGH	`src/renderer/components/chat/sendbox.tsx:241`	`isBtwInput` 声明未使用，lint 警告
2	🔵 LOW	`src/renderer/pages/conversation/platforms/acp/AcpSendBox.tsx:3`	`TMessage` 导入未使用，存量问题

结论

⚠️ 有条件批准 — 存在一处 lint 警告（isBtwInput 未使用变量），处理后可合并。

本报告由本地 pr-review skill 生成，包含完整项目上下文，无截断限制。

CONCLUSION: CONDITIONAL
IS_CRITICAL_PATH: true
PR_NUMBER: 1856

- Remove unused `isBtwInput` declaration that triggered oxlint no-unused-vars warning Review follow-up for iOfficeAI#1856

piorpua · 2026-03-30T14:34:06Z

PR Fix 验证报告

原始 PR: #1856
修复方式: 直接推送到 feat/conversation-command-queue-pr

#	严重级别	文件	问题	修复方式	状态
1	🟠 HIGH	`src/renderer/components/chat/sendbox.tsx:241`	`isBtwInput` 声明未使用，触发 oxlint no-unused-vars 警告	删除未使用的变量声明	✅ 已修复

总结： ✅ 已修复 1 个 | ❌ 未能修复 0 个

🔵 LOW 级别问题（AcpSendBox.tsx TMessage 导入）已跳过（不阻塞合并，存量问题）。

Ericwong5021 changed the title ~~feat(conversation): add command queue workflow~~ feat(conversation): implement command queue workflow Mar 28, 2026

piorpua added the bot:reviewing Review in progress (mutex) label Mar 29, 2026

piorpua added bot:needs-human-review Blocking issues — human must intervene and removed bot:reviewing Review in progress (mutex) labels Mar 29, 2026

Ericwong5021 added 8 commits March 29, 2026 23:43

feat(conversation): add command queue support

4b50ead

fix(conversation): resolve queue TypeScript issues

280f599

fix(conversation): expose command queue while running

e29a972

chore(conversation): add queue debug logs

5fd3bde

feat(conversation): finalize command queue workflow

8abbfba

test(conversation): improve command queue patch coverage

c4d1c8a

refactor(conversation): clean up code formatting and improve readabil…

2c80bcd

…ity in command queue components

Ericwong5021 force-pushed the feat/conversation-command-queue-pr branch from 7f02e4d to 2c80bcd Compare March 29, 2026 15:44

test(conversation): update slash command test expectations

f682050

fix(conversation): improve queued command text contrast in dark mode

b099074

piorpua added bot:reviewing Review in progress (mutex) and removed bot:needs-human-review Blocking issues — human must intervene labels Mar 30, 2026

piorpua added bot:ready-to-fix CONDITIONAL review done, waiting for bot fix bot:fixing Fix in progress (mutex) and removed bot:reviewing Review in progress (mutex) bot:ready-to-fix CONDITIONAL review done, waiting for bot fix labels Mar 30, 2026

fix(sendbox): remove unused isBtwInput variable

3995a17

- Remove unused `isBtwInput` declaration that triggered oxlint no-unused-vars warning Review follow-up for iOfficeAI#1856

piorpua added bot:ready-to-merge Bot done, code is clean — human just needs to confirm and merge and removed bot:fixing Fix in progress (mutex) labels Mar 30, 2026

piorpua enabled auto-merge (squash) March 30, 2026 14:37

piorpua merged commit e9a72a9 into iOfficeAI:main Mar 30, 2026
12 of 14 checks passed

Ericwong5021 deleted the feat/conversation-command-queue-pr branch March 31, 2026 08:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(conversation): implement command queue workflow#1856

feat(conversation): implement command queue workflow#1856
piorpua merged 11 commits intoiOfficeAI:mainfrom
Ericwong5021:feat/conversation-command-queue-pr

Ericwong5021 commented Mar 28, 2026 •

edited

Loading

Uh oh!

piorpua commented Mar 29, 2026

Uh oh!

sentry bot commented Mar 29, 2026

Uh oh!

piorpua commented Mar 30, 2026

Uh oh!

piorpua commented Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Ericwong5021 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope

Functional Boundary

Impacted Areas

Test plan

Uh oh!

piorpua commented Mar 29, 2026

合并冲突（无法自动解决）

Uh oh!

sentry bot commented Mar 29, 2026

Codecov Report

Uh oh!

piorpua commented Mar 30, 2026

Code Review：feat(conversation): implement command queue workflow (#1856)

变更概述

方案评估

问题清单

🟠 HIGH — sendbox.tsx：isBtwInput 声明未使用

🔵 LOW — AcpSendBox.tsx：TMessage 导入未使用（存量问题）

汇总

结论

Uh oh!

piorpua commented Mar 30, 2026

PR Fix 验证报告

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ericwong5021 commented Mar 28, 2026 •

edited

Loading