fix(test): repair broken layout_theme and getNpxCacheDir tests#1849
Merged
fix(test): repair broken layout_theme and getNpxCacheDir tests#1849
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Code Review:fix(test): repair broken layout_theme and getNpxCacheDir tests (#1849)变更概述本 PR 修复了三处测试相关问题:修正了 方案评估结论:✅ 方案合理 三处修复均直接对症:导入路径更新跟随组件重命名; 问题清单✅ 未发现实质性问题。 Oxlint 报告了两处警告( 汇总无问题。 结论✅ 批准合并 — 修复准确,逻辑正确,测试隔离处理规范,无阻塞性问题。 本报告由本地 |
Contributor
|
✅ 已自动 review,无阻塞性问题,正在触发自动合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layout_theme_route_revert.test.tsimport path afterCssThemeSettings→DisplaySettingsrefactorgetNpxCacheDir.test.tsenv leak from Zed editor'snpm_config_cachetests/regression/to vitest config include patternsTest plan
bun run test -- tests/regression/layout_theme_route_revert.test.tspasses (was failing)bun run test -- tests/unit/getNpxCacheDir.test.tspasses (4 were failing)bun run test— no regressions