Skip to content

fix(test): repair broken layout_theme and getNpxCacheDir tests#1849

Merged
piorpua merged 4 commits intomainfrom
fix/broken-tests
Mar 29, 2026
Merged

fix(test): repair broken layout_theme and getNpxCacheDir tests#1849
piorpua merged 4 commits intomainfrom
fix/broken-tests

Conversation

@IceyLiu
Copy link
Copy Markdown
Collaborator

@IceyLiu IceyLiu commented Mar 28, 2026

Summary

  • Fix layout_theme_route_revert.test.ts import path after CssThemeSettingsDisplaySettings refactor
  • Fix getNpxCacheDir.test.ts env leak from Zed editor's npm_config_cache
  • Add tests/regression/ to vitest config include patterns

Test plan

  • bun run test -- tests/regression/layout_theme_route_revert.test.ts passes (was failing)
  • bun run test -- tests/unit/getNpxCacheDir.test.ts passes (4 were failing)
  • Full bun run test — no regressions

@piorpua piorpua added the bot:reviewing Review in progress (mutex) label Mar 29, 2026
@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 29, 2026

Code Review:fix(test): repair broken layout_theme and getNpxCacheDir tests (#1849)

变更概述

本 PR 修复了三处测试相关问题:修正了 layout_theme_route_revert.test.ts 中因 CssThemeSettingsDisplaySettings 重构导致的导入路径失效;在 getNpxCacheDir.test.tsbeforeEach 中清理 Zed 编辑器注入的 npm_config_cache 环境变量,消除测试间污染;将 tests/regression/ 目录添加到 vitest config 的 include 列表,使回归测试能被实际执行。


方案评估

结论:✅ 方案合理

三处修复均直接对症:导入路径更新跟随组件重命名;beforeEach 清理环境变量是测试隔离的标准做法,且与 afterEach 的恢复逻辑配合正确;将 regression/ 加入 include 是必要的配置修复,不引入新抽象。无需改进。


问题清单

✅ 未发现实质性问题。

Oxlint 报告了两处警告(no-shadowconsistent-function-scoping),但均为本 PR 之前已存在的历史代码,非本次改动引入,不作为本 PR 阻塞点。


汇总

无问题。

结论

批准合并 — 修复准确,逻辑正确,测试隔离处理规范,无阻塞性问题。


本报告由本地 pr-review skill 生成,包含完整项目上下文,无截断限制。

@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 29, 2026

✅ 已自动 review,无阻塞性问题,正在触发自动合并。

@piorpua piorpua merged commit d008d58 into main Mar 29, 2026
17 checks passed
@piorpua piorpua deleted the fix/broken-tests branch March 29, 2026 09:25
@piorpua piorpua added bot:done Auto-merged by bot and removed bot:reviewing Review in progress (mutex) labels Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:done Auto-merged by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants