fix(openclaw): catch write errors in deviceAuthStore (ELECTRON-6F)#1835
Merged
fix(openclaw): catch write errors in deviceAuthStore (ELECTRON-6F)#1835
Conversation
…dled rejection Wrap writeStore() in try-catch so filesystem errors (EROFS, EACCES, ENOSPC) do not propagate as unhandled promise rejections. The user will simply need to re-authenticate next session if the write fails. Fixes ELECTRON-6F
Contributor
Code Review：fix(openclaw): catch write errors in deviceAuthStore (ELECTRON-6F) (#1835)变更概述本 PR 修复 Sentry 问题 ELECTRON-6F：将 方案评估结论：✅ 方案合理 重构后的 问题清单✅ 未发现明显问题，代码质量良好，建议批准合并。 汇总
结论✅ 批准合并 — 无阻塞性问题。变更聚焦、正确，测试覆盖完整，lint 零警告。 本报告由本地 CONCLUSION: APPROVED |
Contributor
|
✅ 已自动 review，无阻塞性问题，正在触发自动合并。 |
piorpua
added
bot:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writeStore()indeviceAuthStore.tswith try-catch to handle filesystem errors (EROFS, EACCES, ENOSPC) gracefullySentry Issue
ELECTRON-6F — 4 occurrences, unhandled promise rejection on read-only filesystem (WSL2/Ubuntu)
Closes #1834
Verification
bunx tsc --noEmit— no type errorsbun run lint:fix— 0 errorsbun run format— cleanTest Plan
storeDeviceAuthTokendoes not throw on read-only filesystemclearDeviceAuthTokendoes not throw on read-only filesystem