Skip to content

fix(skills): align SKILL.md name fields with directory names#1833

Merged
piorpua merged 2 commits intomainfrom
fix/skill-naming-convention
Mar 29, 2026
Merged

fix(skills): align SKILL.md name fields with directory names#1833
piorpua merged 2 commits intomainfrom
fix/skill-naming-convention

Conversation

@IceyLiu
Copy link
Copy Markdown
Collaborator

@IceyLiu IceyLiu commented Mar 28, 2026

Summary

  • Fix name field in officecli-academic-paper and officecli-data-dashboard SKILL.md to match directory names (was missing officecli- prefix, causing skill activation validation error)
  • Update /package-assistant command with skill naming convention: directory name = SKILL.md name = defaultEnabledSkills entry, all using officecli- prefix

Test plan

  • Verify academic-paper skill activates correctly (no params/name must be equal to one of the allowed values error)
  • Verify data-dashboard skill activates correctly

IceyLiu added 2 commits March 28, 2026 12:47
officecli-academic-paper and officecli-data-dashboard had mismatched
name fields causing activate_skill validation errors.
@IceyLiu IceyLiu enabled auto-merge March 28, 2026 04:48
@piorpua piorpua added the bot:reviewing Review in progress (mutex) label Mar 29, 2026
@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 29, 2026

Code Review:fix(skills): align SKILL.md name fields with directory names (#1833)

变更概述

本 PR 修复了两个 OfficeCLI skill 的 SKILL.md frontmatter 中 name 字段与目录名不一致的问题:academic-paperofficecli-academic-paperdata-dashboardofficecli-data-dashboard。同步更新了 /package-assistant 命令文档,统一了 skill 命名约定的说明。


方案评估

结论:✅ 方案合理

修复直接针对 params/name must be equal to one of the allowed values 的根因——name 字段须与目录名完全一致。检查已有的 officecli-docxofficecli-pptxofficecli-xlsx 以及 assistantPresets.tsdefaultEnabledSkills 的引用(均已使用 officecli-academic-paper / officecli-data-dashboard),本次修复使三者完全对齐。package-assistant.md 的更新也消除了之前重复追加 officecli- 前缀的逻辑混乱。


问题清单

✅ 未发现明显问题,代码质量良好,建议批准合并。


汇总

无问题。

结论

批准合并 — 修复准确,无阻塞性问题,变更范围有限且完全正确。


本报告由本地 pr-review skill 生成,包含完整项目上下文,无截断限制。

CONCLUSION: APPROVED
IS_CRITICAL_PATH: false
PR_NUMBER: 1833

@piorpua
Copy link
Copy Markdown
Contributor

piorpua commented Mar 29, 2026

✅ 已自动 review,无阻塞性问题,正在触发自动合并。

@piorpua piorpua added bot:done Auto-merged by bot and removed bot:reviewing Review in progress (mutex) labels Mar 29, 2026
@piorpua piorpua disabled auto-merge March 29, 2026 08:51
@piorpua piorpua merged commit 0569d77 into main Mar 29, 2026
4 checks passed
@piorpua piorpua deleted the fix/skill-naming-convention branch March 29, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:done Auto-merged by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants