fix(acp): address review issues from PR #1702#1725
Merged
kaizhou-lab merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
- Remove ineffective vi.mock calls with wrong relative paths that did not intercept source module dependencies - Replace Record<string, any> with Record<string, unknown> in priv() helper to fix no-explicit-any lint warnings Review follow-up for #1702
Contributor
Author
PR Fix 验证报告原始 PR: #1702
总结： ✅ 已修复 2 个 | ❌ 未能修复 0 个 | ⏭️ 跳过 0 个 |
kaizhou-lab
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1702 — addresses all issues identified in the code review.
Issues Fixed
tests/unit/acpConnectionKeepalive.test.ts:26-45vi.mock路径相对测试文件解析，未能拦截源文件模块vi.mock调用，与acpTimeout.test.ts保持一致tests/unit/acpConnectionKeepalive.test.ts:50-51priv()函数使用Record<string, any>触发 lint 警告Record<string, unknown>Related
Follow-up to #1702
Test Plan
bun run test— all tests passbunx tsc --noEmit— no type errorsbun run lint:fix— lint clean