fix(acp): address review issues from PR #1700#1723
Merged
kaizhou-lab merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
- Remove acpAgentTimeoutFinish.test.ts: tested a hand-written stub instead
of the real AcpAgentManager class, providing false coverage confidence
- Fix no-explicit-any lint warnings in acpAgentManagerCronGuard.test.ts:
replace `any` with `unknown`/precise types, use `as unknown as T` for
private property access, replace empty `class {}` mock with `vi.fn()`
Review follow-up for #1700
Contributor
Author
PR Fix 验证报告原始 PR: #1700
总结： ✅ 已修复 3 个 | ❌ 未能修复 0 个 | ⏭️ 跳过 0 个 |
kaizhou-lab
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1700 — addresses all issues identified in the code review.
Issues Fixed
tests/unit/acpAgentTimeoutFinish.test.tsAcpAgentManager, providing false coverage confidenceacpAgentManagerCronGuard.test.tsalready covers the real class with 9 teststests/unit/acpAgentManagerCronGuard.test.tsno-explicit-any/no-extraneous-classlint warningsanywithunknown/precise types, usedas unknown as Tfor private property access, replaced emptyclass {}mock withvi.fn()tests/unit/acpAgentTimeoutFinish.test.tsno-explicit-anylint warningsRelated
Follow-up to #1700
Test Plan
bun run test— 131 test files, 1432 tests, all passbunx tsc --noEmit— no type errorsbun run lint:fix— no acpAgent-related lint warnings remainbun run format— formatting clean