fix(skills): fallback to prompt injection for custom workspaces#1717
Merged
fix(skills): fallback to prompt injection for custom workspaces#1717
Conversation
Custom workspaces skip symlink setup to avoid polluting user directories. When a non-assistant ACP session uses a custom workspace with enabledSkills but no presetContext, skills were completely lost because: 1. No symlinks created (customWorkspace skips setupAssistantWorkspace) 2. Native-support branch only injected presetContext, not skills Now checks both native support AND non-custom workspace before relying on symlink discovery; otherwise falls back to prompt injection.
piorpua
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
src/process/task/AcpAgentManager.tscustomWorkspacecheck to first-message skill injection logiccustomWorkspaceis true, always fallback toprepareFirstMessageWithSkillsIndex(prompt injection) regardless of native skill supportsetupAssistantWorkspace(symlinks) is intentionally skipped for custom workspaces to avoid polluting user directoriesBefore: native-support backends only injected
presetContext→ skills lost when no presetContextAfter: checks both native support AND non-custom workspace → custom workspace always gets prompt injection fallback
Related Issue
Closes #1716
Test Plan
bun run test— all existing tests pass