test(preview): add mtime polling tests for PreviewContext file watch#1714
Merged
kaizhou-lab merged 1 commit intomainfrom Mar 25, 2026
Merged
test(preview): add mtime polling tests for PreviewContext file watch#1714kaizhou-lab merged 1 commit intomainfrom
kaizhou-lab merged 1 commit intomainfrom
Conversation
Cover the checkFileUpdate and closeTab behaviors added in PR #1686: - getFileMetadata called immediately on tab switch - No file read when mtime is unchanged - File content updated when mtime changes - Skip update when tab isDirty - Use getImageBase64 for image content type - No state corruption when file read rejects - getFileMetadata rejection handled without side effects - closeTab clears fileMtimeRef so reopening starts fresh Review follow-up for #1686
Contributor
Author
PR Fix 验证报告原始 PR: #1686
总结： ✅ 已修复 4 个 | ❌ 未能修复 0 个 | ⏭️ 跳过 0 个 |
kaizhou-lab
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1686 — addresses all issues identified in the code review.
Note: Issues #1 (useEffect dependency), #2 (Promise rejection handling), and #4 (fileMtimeRef cleanup in closeTab) were already fixed in the original PR before merge. This PR adds test coverage for Issue #3.
Issues Fixed
PreviewContext.tsx:596–609activeTab对象引用作为 effect 依赖，轮询频繁重置activeFilePath+activeTabRef)PreviewContext.tsx:570,581getFileMetadata和readPromise的 reject 未处理.catchblocks added)tests/unit/previewFileWatch.dom.test.ts(8 cases)PreviewContext.tsx:563fileMtimeRef不随 tab 关闭清理closeTabclears the entry)Test Cases Added
getFileMetadatacalled immediately on tab switchisDirty = truegetImageBase64(notreadFile) for image content typegetFileMetadatarejection handled without side effectscloseTabclearsfileMtimeRefso reopening a file starts freshRelated
Follow-up to #1686
Test Plan
bun run test— all tests pass (1401 passed)bunx tsc --noEmit— no type errorsbun run lint:fix— lint cleanbun run format— format clean