fix(skills): complete native skill symlink mapping and add prompt injection fallback#1713
Merged
fix(skills): complete native skill symlink mapping and add prompt injection fallback#1713
Conversation
added 4 commits
March 25, 2026 20:39
…ection fallback - Add all verified backends to AGENT_SKILLS_DIRS (codex, qwen, iflow, goose, droid, kimi, vibe, cursor) - Fix codebuddy mapping from .claude/skills to .codebuddy/skills - Remove broken DEFAULT_SKILLS_DIRS (.agents/skills/) fallback that no CLI scans - Export hasNativeSkillSupport() for callers to check backend support - Change symlink type from 'dir' to 'junction' for Windows compatibility - AcpAgentManager: fallback to prepareFirstMessageWithSkillsIndex for unsupported backends - Add 19 unit tests covering hasNativeSkillSupport and setupAssistantWorkspace Closes #1712
…tibility - Use vi.hoisted() for mock tracking variables to ensure proper initialization - Normalize all paths to forward slashes in mock functions (stat, lstat, symlink, existsSync) - Replace path.join() in assertions with hardcoded forward-slash paths - Fixes CI failure on Windows where backslash paths didn't match mock keys
piorpua
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_SKILLS_DIRSmapping and adding prompt injection fallback for unsupported CLIs'dir'→'junction').claude/skillsto.codebuddy/skillsChanges
src/process/utils/initAgent.tsAGENT_SKILLS_DIRSfrom 3 to 11 backends (add codex, qwen, iflow, goose, droid, kimi, vibe, cursor)DEFAULT_SKILLS_DIRS(.agents/skills/) fallback — no CLI natively scans ithasNativeSkillSupport()function for callers to check backend support'dir'to'junction'(no admin privileges needed on Windows; no-op on macOS/Linux)setupAssistantWorkspacereturns early for unsupported backends (caller should use prompt injection)src/process/task/AcpAgentManager.tshasNativeSkillSupportandprepareFirstMessageWithSkillsIndexprepareFirstMessageWithSkillsIndex(rules + skills index injected into first message)tests/unit/initAgent.skills.test.ts(new)hasNativeSkillSupportandsetupAssistantWorkspaceRelated Issue
Closes #1712
Test Plan
.codex/skills/symlink