fix: ensure SQLite WAL is checkpointed on graceful shutdown#1696
Merged
fix: ensure SQLite WAL is checkpointed on graceful shutdown#1696
Conversation
- Remove stale WAL (-wal) and shared-memory (-shm) sidecar files
during DB recovery to prevent infinite recovery loop on next start
- Track resolved DB instance synchronously so closeDatabase() can
close the connection from process.on('exit') handlers (no await)
- Add isShuttingDown guard to prevent re-entrant shutdown on double signal
- Call closeDatabase() explicitly in shutdown() before server close,
and as a safety net in process.on('exit')
IceyLiu
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-wal) and shared-memory (-shm) sidecar files during DB recovery to prevent an infinite recovery loop caused by SQLite replaying the stale WAL against a freshly created databaseAionUIDatabaseinstance synchronously (dbResolved) socloseDatabase()can be called fromprocess.on('exit')handlers without needing to await a PromiseisShuttingDownguard to prevent re-entrant shutdown on double signal (e.g. two CTRL+C)closeDatabase()explicitly in theshutdown()handler before closing the server, withprocess.on('exit')as a final safety netTest plan
-wal/-shmfilesbun run test)