test: mock UserRepository in webuiQR unit test#1695
Merged
kaizhou-lab merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
better-sqlite3 native module version mismatch causes database initialization to fail in the test environment, making verifyQRTokenDirect always return success=false. Mock UserRepository.getSystemUser, updateLastLogin, and updateJwtSecret so the test runs without a real database, isolating the QR token logic under test.
kaizhou-lab
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyQRTokenDirectunit test was failing becausebetter-sqlite3native module was compiled for a different Node.js version, causing database initialization to throwERR_DLOPEN_FAILEDvi.mockforUserRepositoryto stubgetSystemUser,updateLastLogin, andupdateJwtSecret, so the test runs without a real databasewebuiQR.test.tsnow passTest plan
bun run test— 0 failurestests/unit/webuiQR.test.tspasses all 5 cases including "accepts a freshly generated token"