chore: fix test local env isolation and cleanup tooling#1694
Merged
Conversation
added 2 commits
March 25, 2026 10:58
…unit test - Mock ProcessConfig in acpSessionCapabilities tests to prevent reading real local MCP config, ensuring consistent results across environments - Remove BetterSqlite3Driver unit test: the driver is a pure thin wrapper with no logic to test, and loading the native module creates an unavoidable NMV conflict between Electron (NMV 136) and Node 22 (NMV 127)
IceyLiu
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessConfiginacpSessionCapabilitiestests to prevent reading real local MCP config — fixes local-only test failures that passed on CIBetterSqlite3Driverunit test: pure thin wrapper with no logic to test, and its native module creates an unavoidable NMV conflict between Electron (NMV 136) and Node 22 test runner (NMV 127)oss-prcommand to simpler self-contained versioncommitskill (redundant with updatedoss-prflow)Test plan
bun run testpasses locally withoutnpm rebuild better-sqlite3bun run start(Electron) still works afterbun install