Skip to content

feat(search): add Cmd/Ctrl+Shift+F history shortcut#1625

Merged
kaizhou-lab merged 1 commit intoiOfficeAI:mainfrom
Eric-Song-Nop:global-search
Mar 24, 2026
Merged

feat(search): add Cmd/Ctrl+Shift+F history shortcut#1625
kaizhou-lab merged 1 commit intoiOfficeAI:mainfrom
Eric-Song-Nop:global-search

Conversation

@Eric-Song-Nop
Copy link
Copy Markdown
Contributor

Summary

  • add Cmd/Ctrl+Shift+F to open the existing sidebar conversation history search on desktop
  • keep Cmd/Ctrl+F scoped to the in-conversation minimap search
  • treat this as a common global search shortcut so the existing feature is easier to discover

Changes

  • add a desktop-only keyboard listener in ConversationSearchPopover for Cmd/Ctrl+Shift+F
  • exclude Shift from the minimap Cmd/Ctrl+F handler to avoid opening both search UIs
  • extend DOM coverage for the sidebar search shortcut and the minimap regression case

Related Issue

Closes #1624

Test Plan

  • bun run lint:fix
  • bun run format
  • bunx tsc --noEmit
  • bun run test

@sentry
Copy link
Copy Markdown

sentry bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ation/GroupedHistory/ConversationSearchPopover.tsx 92.30% 0 Missing and 1 partial ⚠️
...onents/ConversationTitleMinimap/useMinimapPanel.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@kaizhou-lab kaizhou-lab merged commit 5f1cbf8 into iOfficeAI:main Mar 24, 2026
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(search): add common global search shortcut for history search

2 participants