fix(image-generation-mcp): address review issues from PR #1505#1601
Merged
fix(image-generation-mcp): address review issues from PR #1505#1601
Conversation
- Fix clearImageGenerationAgentStatus calling ConfigStorage.set inside React state updater, causing potential double invocation in Strict Mode; move side effect outside the updater and pass direct value to setter - Refactor getDetectionTarget to reuse getAgentForConfig, eliminating duplicated fork-Gemini detection logic Review follow-up for #1505
Contributor
Author
PR Fix 验证报告原始 PR: #1505
总结： ✅ 已修复 2 个 | ⏭️ 跳过 1 个（lint 规则限制） |
Add Step 7 to run oxlint on changed .ts/.tsx files before reading file contents. The lint output serves as a baseline so that lint-clean patterns are not flagged as style issues during review. Renumber subsequent steps (7->8, 8->9, 9->10, 10->11) accordingly.
IceyLiu
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1505 — addresses all issues identified in the code review.
Issues Fixed
ToolsModalContent.tsx:394clearImageGenerationAgentStatuscallsConfigStorage.setinside React state updater, causing potential double invocation in Strict ModesetAgentInstallStatusMcpService.ts:151getDetectionTargetduplicates the fork-Gemini detection logic already present ingetAgentForConfiggetDetectionTargetto callgetAgentForConfig, eliminating the duplicate conditionalRelated
Follow-up to #1505
Test Plan
bun run test— all tests pass (1160 passed)bunx tsc --noEmit— no type errorsbunx oxlint --fix— lint clean (0 warnings, 0 errors)bunx oxfmt— format cleanclearImageGenerationAgentStatusno longer triggers doubleConfigStorage.setin React Strict Mode