fix(fs): handle ENOENT in readDirectoryRecursive and bridge providers#1450
Merged
fix(fs): handle ENOENT in readDirectoryRecursive and bridge providers#1450
Conversation
Add try/catch around fs.stat() calls in readDirectoryRecursive() to handle deleted temp workspaces (gemini-temp-*, claude-temp-*) and race conditions where files are removed between readdir and stat. Also harden bridge providers (getFilesByDir, getFileMetadata, getWorkspace) to never throw, since the bridge library's provider callback has no .catch handler — any thrown error becomes an unhandled promise rejection reported to Sentry. Fixes ELECTRON-5Y, ELECTRON-5Z, ELECTRON-60, ELECTRON-61, ELECTRON-62 Closes #1434, #1436, #1437, #1438, #1439
IceyLiu
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.stat()calls inreadDirectoryRecursive()to handle deleted temp workspaces (gemini-temp-*,claude-temp-*) and race conditions where files are removed betweenreaddirandstatgetFilesByDir,getFileMetadata,getWorkspace) to never throw — the bridge library's provider callback has no.catchhandler, so any thrown error becomes an unhandled promise rejection reported to SentryTest plan
readDirectoryRecursivereturnsnullfor non-existent directoryreadDirectoryRecursivereturnsnullfor cleaned-up temp workspacereadDirectoryRecursiveskips files deleted between readdir and statFixes ELECTRON-5Y, ELECTRON-5Z, ELECTRON-60, ELECTRON-61, ELECTRON-62
Closes #1434, #1436, #1437, #1438, #1439