docs(specs): update phase2 design doc post PR #1402 merge#1413
Merged
kaizhou-lab merged 1 commit intomainfrom Mar 18, 2026
Merged
docs(specs): update phase2 design doc post PR #1402 merge#1413kaizhou-lab merged 1 commit intomainfrom
kaizhou-lab merged 1 commit intomainfrom
Conversation
- Mark PR #1402 as merged in header metadata - Update branch name to phase2-specific branch - Add two missing coupling entries: applicationBridge and conversationBridge line 125 - PR-A: add listAllConversations to IConversationRepository interface; fix conversationBridge line 125 - PR-B: add applicationBridge.ts decoupling with same injection pattern - PR-F: document channels layer migration targets (SystemActions, ActionExecutor) - Testing: add Test Quality Rules section with behavior-first, risk-first guidelines - Testing: annotate all failure paths with [failure path], reorder CronService tests by risk - Testing: add conversationBridge and applicationBridge to coverage targets
kaizhou-lab
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phase2-specificapplicationBridge.tsandconversationBridge.tsline 125IConversationRepositorywithlistAllConversations(); document fix forconversationBridgeline 125 residual couplingapplicationBridge.tsdecoupling (same injection pattern as other bridges)src/channels/actions/SystemActions.tsandsrc/channels/gateway/ActionExecutor.tsalso need migration[failure path]; reorder CronService test scenarios by risk priorityTest plan