Skip to content

fix(ci): remove secrets context from if: conditions in coverage job#1410

Merged
IceyLiu merged 1 commit intomainfrom
zynx/fix/remove-secrets-from-if-conditions
Mar 18, 2026
Merged

fix(ci): remove secrets context from if: conditions in coverage job#1410
IceyLiu merged 1 commit intomainfrom
zynx/fix/remove-secrets-from-if-conditions

Conversation

@piorpua
Copy link
Copy Markdown
Contributor

@piorpua piorpua commented Mar 18, 2026

Summary

  • GitHub Actions prohibits referencing secrets context in if: expressions — only run: and with: are allowed
  • Removed secrets.CODECOV_TOKEN != '' from the upload step's if: condition; fail_ci_if_error: false already handles missing tokens gracefully
  • Simplified the skip step condition and removed an invalid secrets expression from the run: block

Test plan

  • Trigger any PR and confirm the PR Checks workflow starts successfully (duration > 0)
  • Verify Code Quality check reports results (no longer stuck pending)
  • Verify Coverage Test job completes without workflow validation errors

@IceyLiu IceyLiu merged commit e92a84a into main Mar 18, 2026
15 checks passed
@piorpua piorpua deleted the zynx/fix/remove-secrets-from-if-conditions branch March 18, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants