Skip to content

fix(tray): refresh recent chats after conversation changes#1398

Merged
ringringlin merged 3 commits intoiOfficeAI:mainfrom
cdxiaodong:fix/tray-refresh-after-conversation-mutation
Mar 19, 2026
Merged

fix(tray): refresh recent chats after conversation changes#1398
ringringlin merged 3 commits intoiOfficeAI:mainfrom
cdxiaodong:fix/tray-refresh-after-conversation-mutation

Conversation

@cdxiaodong
Copy link
Copy Markdown
Member

Summary

  • refresh the tray menu after conversation create, delete, and rename mutations
  • keep tray recent chats aligned with conversation changes from the desktop UI and WebUI
  • add unit coverage for tray refresh behavior in conversation bridge

Testing

  • bun run test tests/unit/conversationBridge.tray.test.ts tests/unit/tray.test.ts
  • bunx tsc --noEmit
  • bun run test (currently fails in existing tests: tests/unit/configureChromium.test.ts and a full-suite mock interference affecting tests/unit/tray.test.ts)

cdxd and others added 3 commits March 18, 2026 13:44
Integrate refreshTrayMenuSafely calls into the refactored
conversationBridge that now uses IConversationService and
IWorkerTaskManager dependency injection.
Adapt test mocks to use IConversationService and IWorkerTaskManager
dependency injection parameters instead of direct module mocks.
Add listChanged.emit to ipcBridge mock for emitConversationListChanged.
@sentry
Copy link
Copy Markdown

sentry bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/process/bridge/conversationBridge.ts 66.66% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@ringringlin ringringlin merged commit 637227d into iOfficeAI:main Mar 19, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants