fix: stabilize tray test CI & always show SkillsMarketBanner desc/details#1380
Merged
fix: stabilize tray test CI & always show SkillsMarketBanner desc/details#1380
Conversation
added 2 commits
March 17, 2026 20:37
Use a shared top-level mockBuildFromTemplate reference instead of re-importing Menu from electron after vi.resetModules(), which caused intermittent undefined in CI environments.
Remove compact mode that hid description and details link when the switch was enabled. The banner now consistently displays the full description and details link regardless of toggle state.
piorpua
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1379
Summary
mockBuildFromTemplatereference instead of re-importingMenufrom electron aftervi.resetModules(), which caused intermittentundefinedin CI (Ubuntu)skillsMarketDescandskillsMarketDetailsare always visible regardless of switch stateConfigStorage.getto ensure the banner renders in WebUI mode where the IPC bridge is unavailableTest plan
bun run test -- tests/unit/tray.test.tspasses locally