Skip to content

fix(guid): remove add-assistant button hover animation#1362

Merged
IceyLiu merged 2 commits intoiOfficeAI:mainfrom
TCP404:fix/add-assistant-button-flicker
Mar 17, 2026
Merged

fix(guid): remove add-assistant button hover animation#1362
IceyLiu merged 2 commits intoiOfficeAI:mainfrom
TCP404:fix/add-assistant-button-flicker

Conversation

@TCP404
Copy link
Copy Markdown
Collaborator

@TCP404 TCP404 commented Mar 17, 2026

Pull Request

Description

The "+" (Add Assistant) button at the end of the assistant label row flickers rapidly when the mouse hovers over it, making it completely unclickable.

Root cause: The button expands from 28px to up to 320px on hover via max-width transition. When the button sits near the end of a flex-wrap row, the expansion causes it to wrap to the next line → mouse leaves → button shrinks back → re-enters the row → hover triggers again → infinite loop.

Fix: Remove the hover expand animation entirely. The button is now a static circular "+" icon (28×28) with only a background color change on hover. This eliminates the reflow issue at its source and keeps the UI simple.

Related Issues

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

  • Tested on macOS
  • Tested on Windows
  • Tested on Linux
  • My code follows the project's code style guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings or errors

Screenshots

Before (Bug)

Default state (inline) Hover state (wrapped to next line)
image image

After (Fixed)

Static "+" button, no expand animation on hover.

Additional Context

The bug is triggered when the "+" button is positioned near the end of a flex-wrap row with just enough space for the collapsed state (28px) but not for the expanded state. Resizing the window to make the button sit at the row boundary reliably reproduces the issue.

@TCP404 TCP404 force-pushed the fix/add-assistant-button-flicker branch from 067445f to 01bbbe4 Compare March 17, 2026 08:51
@IceyLiu
Copy link
Copy Markdown
Collaborator

IceyLiu commented Mar 17, 2026

@TCP404 解决方案不太合适,帮忙把hover变形展开直接去掉,保留➕即可

@IceyLiu IceyLiu self-assigned this Mar 17, 2026
Remove the expand animation on hover to avoid layout flicker.
The button is now a static circular "+" icon with only a
background color change on hover.
@TCP404 TCP404 force-pushed the fix/add-assistant-button-flicker branch from 01bbbe4 to 4eb7f56 Compare March 17, 2026 11:31
@TCP404 TCP404 changed the title fix(guid): prevent add-assistant button flicker on hover fix(guid): remove add-assistant button hover animation Mar 17, 2026
@IceyLiu IceyLiu merged commit 7ba711b into iOfficeAI:main Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "+" button at the end of Label row flickers and is unclickable

2 participants