Skip to content

update expired wx group qr code#1346

Merged
piorpua merged 1 commit intomainfrom
update_readme
Mar 17, 2026
Merged

update expired wx group qr code#1346
piorpua merged 1 commit intomainfrom
update_readme

Conversation

@IceyLiu
Copy link
Copy Markdown
Collaborator

@IceyLiu IceyLiu commented Mar 17, 2026

Pull Request

Description

Related Issues

  • Closes #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

  • Tested on macOS
  • Tested on Windows
  • Tested on Linux
  • My code follows the project's code style guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings or errors

Screenshots

Additional Context


Thank you for contributing to AionUi! 🎉

@piorpua piorpua merged commit db2a8c0 into main Mar 17, 2026
19 checks passed
@piorpua piorpua deleted the update_readme branch March 17, 2026 01:19
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

MEDIUM Issues

1. README links now depend on a new filename; ensure the asset is actually shipped/published everywhere

File: readme.md:34-34

<strong>💬 Community:</strong> <a href="https://discord.gg/2QAwJn7Egx" target="_blank">Discord (English)</a> | <a href="./resources/wechat_group_5.png" target="_blank">微信 (中文群)</a> | <a href="https://twitter.com/AionUI" target="_blank">Twitter</a>

Problem: This PR renames the QR image from wechat_group4.png to wechat_group_5.png and updates multiple README variants accordingly. That’s fine for GitHub rendering, but it can break in other distribution contexts if resources/ is not included (or is filtered) in any docs publishing pipeline, website sync, or release packaging scripts that previously referenced/whitelisted the old filename. Since the change spans 8 README files, any missed pipeline will result in a broken community link/image.

Fix: Verify/update any docs/site/release asset inclusion rules to include resources/wechat_group_5.png (and remove the old one if explicitly listed). Concretely:

  • Search for wechat_group4.png and wechat_group_5.png in CI/docs scripts and website build configs.
  • If there is an allowlist (common in static site generators), add resources/wechat_group_5.png.
  • Optionally keep a compatibility copy (or symlink where supported) for one release cycle if external references might exist.

Summary

Level Count
CRITICAL 0
HIGH 0
MEDIUM 1

🤖 This review was generated by AI and may contain inaccuracies. Please focus on issues you agree with and feel free to disregard any that seem incorrect. Thank you for your contribution!

Note: The following inputs were truncated due to size limits: file contents (>80K chars).
Please review the omitted portions manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants