-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Bug]: Cmd+F search shortcut doesn't work when chat is inside a folder or on mobile #1693
Copy link
Copy link
Closed
Description
Bug Description
The Cmd+F (search conversation content) keyboard shortcut silently stops working when a conversation is inside a folder (which activates tabs) or when the window is narrow enough to trigger mobile layout. The shortcut listener is tied to a component that doesn't render in these cases.
Steps to Reproduce
- Open AionUi
- Create a folder and move a conversation into it
- Open that conversation (tabs appear at the top)
- Press Cmd+F (or Ctrl+F on Windows/Linux)
- Nothing happens — search panel does not appear
Alternative reproduction:
- Open any conversation
- Resize the window below 768px width (mobile layout kicks in)
- Press Cmd+F
- Nothing happens
Root Cause
The Cmd+F shortcut listener lives inside ConversationTitleMinimap, which is rendered inside ChatTitleEditor. In ChatLayout, ChatTitleEditor is gated behind !layout?.isMobile && !hasTabs — so when tabs are active (folder chat) or the window is narrow (mobile), the component unmounts and the shortcut listener is gone.
Affected Files (fixed in #1692)
ChatLayout/index.tsx— +2: render hidden minimap whenhasTabs || isMobileConversationTitleMinimap/index.tsx— +36 −27:hideTriggerprop conditionally hides trigger, panel stays activeminimapTypes.ts— +2: addedhideTriggerprop to typeminimapUtils.ts— +5 −2:getPanelWidthadapts to narrow viewportsuseMinimapPanel.ts— +19 −12: header-centered positioning + vertical clampingminimapPanelWidth.dom.test.ts— +45: new test file, 5 tests
Diff
+109 −41 across 6 files (5 source + 1 new test file)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels