Fix DShot beeper arming feedback loop#11306
Merged
sensei-hacker merged 1 commit intoiNavFlight:maintenance-9.xfrom Feb 8, 2026
Merged
Fix DShot beeper arming feedback loop#11306sensei-hacker merged 1 commit intoiNavFlight:maintenance-9.xfrom
sensei-hacker merged 1 commit intoiNavFlight:maintenance-9.xfrom
Conversation
When arming fails, the FC plays a confirmation beep. If DShot beeper is enabled, this beep sets a guard delay that blocks arming for 1.12s (required by DShot protocol timing). If the user attempts to arm again within this period, it fails due to ARMING_DISABLED_DSHOT_BEEPER and beeps again, resetting the timer and creating an infinite loop. The fix prevents beeping when the ONLY arming blocker is the DShot beeper guard delay itself. This breaks the feedback loop while preserving useful audio feedback for all legitimate arming issues. Modified: src/main/fc/fc_core.c - Added check: only beep if (armingFlags & ~ARMING_DISABLED_DSHOT_BEEPER) - Prevents beeping when only blocked by DShot beeper guard delay - Preserves beeping for GPS, calibration, RC, and other real blockers Fixes user reports of continuous motor beeping and inability to arm when DShot beeper feature is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a feedback loop where the DShot beeper feature prevents arming indefinitely when enabled. When arming fails, the FC plays a confirmation beep using DShot. This sets a guard delay (1.12 seconds) that blocks arming to comply with DShot protocol timing. If the user attempts to arm again within this period, it fails due to ARMING_DISABLED_DSHOT_BEEPER and beeps again, resetting the timer and creating an infinite loop.
Changes
src/main/fc/fc_core.cline 599(armingFlags & ~ARMING_DISABLED_DSHOT_BEEPER)Root Cause
The guard delay is necessary and correct per DShot protocol specification (beep duration + transmission time + minimum spacing = 1.12s). However, beeping to notify the user "you can't arm because I just beeped" provides no value and triggers the loop.
Testing
claude/developer/scripts/testing/inav/dshot/test_dshot_beeper_arming_loop_fix.pyLogical verification confirms:
Impact
Fixes user reports of continuous motor beeping and inability to arm when DShot beeper is enabled. Risk is low - the change is narrowly scoped to prevent only the specific beep that causes the loop.