Skip to content

Blackbox - remove unused setting #11236

Closed
error414 wants to merge 2 commits intoiNavFlight:maintenance-10.xfrom
error414:blackbox-remove-unused-parametr
Closed

Blackbox - remove unused setting #11236
error414 wants to merge 2 commits intoiNavFlight:maintenance-10.xfrom
error414:blackbox-remove-unused-parametr

Conversation

@error414
Copy link
Contributor

@error414 error414 commented Jan 10, 2026 •
edited by qodo-code-review bot
Loading

User description

Removed invertedCardDetection settings.

Ussage of setting has been removed by digitaentity in commit
3b2f87b "Refactor SDCARD; Separate generic code from SPI-specific code"

In next commit 986980c "Convert targets to new SDCARD defines"

the setting has been replaced by "#define"
#if defined(SDCARD_DETECT_INVERTED) return !result; #else return result; #endif

PR Type

Enhancement

Description

  • Remove unused invertedCardDetection setting from blackbox configuration

  • Setting was replaced by SDCARD_DETECT_INVERTED preprocessor define

  • Clean up struct definition, documentation, and settings configuration

Diagram Walkthrough

flowchart LR
  A["blackboxConfig_t struct"] -->|remove field| B["invertedCardDetection removed"]
  C["blackbox.c config"] -->|remove default| B
  D["settings.yaml"] -->|remove setting| B
  E["Settings.md docs"] -->|remove documentation| B
Loading

File Walkthrough
Relevant files
Enhancement
blackbox.h
Remove invertedCardDetection field from struct                     

src/main/blackbox/blackbox.h

  • Remove uint8_t invertedCardDetection field from blackboxConfig_t
    struct
  • Simplify configuration structure by eliminating unused member
 +0/-1     
blackbox.c
Remove invertedCardDetection initialization                           

src/main/blackbox/blackbox.c

  • Remove .invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTION
    initialization from PG_RESET_TEMPLATE
  • Clean up default configuration values
 +0/-1     
Configuration changes
settings.yaml
Remove sdcard_detect_inverted setting definition                 

src/main/fc/settings.yaml

  • Remove sdcard_detect_inverted setting definition
  • Remove description, default value, field mapping, and condition
  • Eliminate setting that was replaced by preprocessor define
 +0/-6     
Documentation
Settings.md
Remove sdcard_detect_inverted documentation                           

docs/Settings.md

  • Remove sdcard_detect_inverted documentation section
  • Remove explanation about SD card detection behavior and hardware
    variants
 +0/-10   

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.

This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 10, 2026 •
edited
Loading

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Jan 10, 2026 •
edited
Loading

PR Code Suggestions ✨

No code suggestions found for the PR.

@sensei-hacker sensei-hacker added this to the 9.1 milestone Jan 13, 2026
DzikuVx
DzikuVx requested changes Jan 22, 2026
View reviewed changes
src/main/blackbox/blackbox.c
.device = DEFAULT_BLACKBOX_DEVICE,
.rate_num = SETTING_BLACKBOX_RATE_NUM_DEFAULT,
.rate_denom = SETTING_BLACKBOX_RATE_DENOM_DEFAULT,
.invertedCardDetection = BLACKBOX_INVERTED_CARD_DETECTION,
Copy link
Member

@DzikuVx DzikuVx Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, PG_REGISTER_WITH_RESET_TEMPLATE(blackboxConfig_t, blackboxConfig, PG_BLACKBOX_CONFIG, 4); needs to use bigger PG version or settings will be broken after flashing

@sensei-hacker sensei-hacker changed the base branch from master to maintenance-10.x January 22, 2026 12:36
@sensei-hacker sensei-hacker modified the milestones: 9.1, 10.0 Jan 22, 2026
@sensei-hacker sensei-hacker mentioned this pull request Jan 22, 2026
Merged
sensei-hacker added a commit to sensei-hacker/inav_unofficial_targets that referenced this pull request Jan 22, 2026
@sensei-hacker
Add GitHub Action to detect PG version increment issues
5eae507 
Create automated check that runs on PRs to detect when parameter group
structs are modified without incrementing the version number. This
prevents settings corruption issues like those seen in PR iNavFlight#11236.

Detection logic:
- Scans changed C/H files for PG_REGISTER entries
- Detects struct typedef modifications in git diff
- Verifies version parameter was incremented
- Posts helpful comment if version not incremented

Files added:
- .github/scripts/check-pg-versions.sh - Detection script
- .github/workflows/pg-version-check.yml - Workflow definition
- .github/workflows/README.md - Workflow documentation

The check is non-blocking (comment only) to avoid false positive build
failures, but provides clear guidance on when versions must be incremented.
This was referenced Jan 22, 2026
Merged
Closed
@sensei-hacker
Copy link
Member

sensei-hacker commented Jan 23, 2026 •
edited
Loading

I will absolutely make the same mistake myself some day unless there is something to stop me.
So I added a build-time check to catch it.

daijoubu pushed a commit to daijoubu/inav that referenced this pull request Jan 26, 2026
@sensei-hacker @daijoubu
Add GitHub Action to detect PG version increment issues
ac6c874 
Create automated check that runs on PRs to detect when parameter group
structs are modified without incrementing the version number. This
prevents settings corruption issues like those seen in PR iNavFlight#11236.

Detection logic:
- Scans changed C/H files for PG_REGISTER entries
- Detects struct typedef modifications in git diff
- Verifies version parameter was incremented
- Posts helpful comment if version not incremented

Files added:
- .github/scripts/check-pg-versions.sh - Detection script
- .github/workflows/pg-version-check.yml - Workflow definition
- .github/workflows/README.md - Workflow documentation

The check is non-blocking (comment only) to avoid false positive build
failures, but provides clear guidance on when versions must be incremented.
@error414 error414 closed this Jan 27, 2026
@error414 error414 deleted the blackbox-remove-unused-parametr branch January 27, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DzikuVx DzikuVx DzikuVx requested changes

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@error414 @sensei-hacker @DzikuVx