Add guard for logic conditions bitmask if max exceeds 64#11173
Merged
sensei-hacker merged 1 commit intoiNavFlight:maintenance-9.xfrom Dec 21, 2025
Merged
Conversation
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Adds a guard to the MSP2_INAV_LOGIC_CONDITIONS_CONFIGURED handler to use
MIN(MAX_LOGIC_CONDITIONS, 64)instead of hardcoded 64. This prevents potential issues if MAX_LOGIC_CONDITIONS is increased beyond 64 in the future.Changes
MIN(MAX_LOGIC_CONDITIONS, 64)in the loop boundTesting
Code review only.
PR Type
Enhancement
Description
Add MSP2_INAV_LOGIC_CONDITIONS_CONFIGURED command for efficient condition status
Returns 8-byte bitmask indicating which logic conditions differ from defaults
Enables configurator optimization reducing MSP requests from 64 to 1+N
Guard loop with MIN(MAX_LOGIC_CONDITIONS, 64) for future-proofing
Diagram Walkthrough
File Walkthrough
fc_msp.c
Implement logic conditions configured bitmask handlersrc/main/fc/fc_msp.c
values
msp_protocol_v2_inav.h
Add MSP protocol definition for configured conditionssrc/main/msp/msp_protocol_v2_inav.h
0x203C