Merged
Conversation
Contributor
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
sensei-hacker
approved these changes
Nov 4, 2025
Member
sensei-hacker
left a comment
sensei-hacker
left a comment
There was a problem hiding this comment.
Looks great to me, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Refactors throttle gauge skip logic to use quantized values
Replaces absolute difference threshold with exact quantization match
Improves rendering efficiency by reducing unnecessary redraws
Diagram Walkthrough
flowchart LR A["Throttle Position Input"] --> B["Quantize: thrPos / (OSD_THROTTLE_GAUGE_HEIGHT_ROWS * 2)"] B --> C["Compare with Previous Quantized Value"] C --> D{"Values Match?"} D -->|Yes| E["Skip Redraw"] D -->|No| F["Redraw Gauge"] F --> G["Update Previous Value"]File Walkthrough
osd_canvas.c
Quantize throttle gauge skip logicsrc/main/io/osd_canvas.c
ABS(prevThr - thrPos) < 10toprevThr ==(uint8_t)(thrPos / (OSD_THROTTLE_GAUGE_HEIGHT_ROWS * 2))prevThrassignment to store quantized throttle value insteadof raw position
control