Add flights counter to stats by TransientTetra · Pull Request #10020 · iNavFlight/inav

TransientTetra · 2024-05-11T18:23:18Z

I'm proposing a new field to be added to stats, flight counter, i.e. number of flights. I used an assumption that a flight counts once the craft is armed and disarmed and a certain time passes between the two (same as other fields); but only once per each battery pack. I also used uint32 for the field, which I feel is a bit excessive; for uint16 max number of flights would be 32768, I'm leaning on your judgement on that matter.

MrD-RC · 2024-05-12T07:41:45Z

I think uint16_t would be plenty to be honest. That's enough for 1 flight a day for 179 years 🤣

MrD-RC · 2024-05-12T07:45:33Z

I'm wondering if it needs better detection for incrementing the number of flights. Just relying on the arm/disarm action can provide false positives.

src/main/fc/stats.c

src/main/fc/stats.h

src/main/fc/fc_init.c

src/main/fc/settings.yaml

src/main/fc/stats.h

stronnag

Please update the PG Template version as you've added a field;

PG_REGISTER_WITH_RESET_TEMPLATE(statsConfig_t, statsConfig, PG_STATS_CONFIG, 1);

i.e. from 1 to 2

TransientTetra · 2024-06-11T13:48:10Z

Any updates on this?

src/main/fc/stats.c

breadoven · 2024-06-13T09:20:50Z

Any updates on this?

Seems OK to me other than the minor formatting comment I made.

OptimusTi

I'd increase this number to avoid false flights due to distance accumulation during armed workbench tests, if that makes sense.

src/main/fc/stats.c

Co-authored-by: OptimusTi <[email protected]>

TransientTetra · 2024-07-06T19:24:45Z

Any additional suggestions or requests on this? Style now is according to @breadoven request, min flight distance was changed to 30m

TransientTetra · 2024-07-25T18:58:07Z

Hey, how do we go forward with this?

completed

sensei-hacker · 2025-10-12T00:38:15Z

It sounds like all of the comments have been addressed.

Has anyone other than the developer tested this? If not, can someone please do so?
In particular, we're interested in testing for anything that might break things, as opposed to it working as expected when all conditions are good. Is there any way this can break the stats screen or otherwise cause a problem?

The request was handled

sensei-hacker · 2025-10-13T04:53:40Z

/review

qodo-code-review · 2025-10-13T04:54:08Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

⚡ Recommended focus areas for review

Possible Overflow

stats_flight_count is defined as uint16_t, but increments are done via prev_flight_count + 1 without guarding against wraparound or capping at UINT16_MAX. Confirm intended wrap behavior or add bounds checking.

void statsOnDisarm(void)
{
    if (statsConfig()->stats_enabled) {
        uint32_t dt = (millis() - arm_millis) / 1000;
        if (dt >= MIN_FLIGHT_TIME_TO_RECORD_STATS_S) {
            statsConfigMutable()->stats_total_time += dt;   //[s]
            statsConfigMutable()->stats_total_dist += (getTotalTravelDistance() - arm_distance_cm) / 100;   //[m]
#ifdef USE_GPS
            // flight counter is incremented at most once per power on
            if (sensors(SENSOR_GPS)) {
                if ((getTotalTravelDistance() - arm_distance_cm) / 100 >= MIN_FLIGHT_DISTANCE_M) {
                    statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
                }
            } else {
                statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
            }
#else
            statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
#endif // USE_GPS

Init Timing

statsInit is called late in init(); ensure no arm/disarm events can occur before prev_flight_count is captured, or make prev_flight_count lazy-loaded from statsConfig on first use to avoid a stale zero if ordering changes.

void statsInit(void)
{
    prev_flight_count = statsConfig()->stats_flight_count;
}

GPS Distance Threshold

When GPS is present, flights shorter than MIN_FLIGHT_DISTANCE_M are not counted; when GPS absent, all qualifying time flights are counted. Verify this asymmetric behavior is intended and won’t penalize indoor GPS-enabled use or cold-starts with low distance due to poor fix.

#ifdef USE_GPS
            // flight counter is incremented at most once per power on
            if (sensors(SENSOR_GPS)) {
                if ((getTotalTravelDistance() - arm_distance_cm) / 100 >= MIN_FLIGHT_DISTANCE_M) {
                    statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
                }
            } else {
                statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
            }
#else
            statsConfigMutable()->stats_flight_count = prev_flight_count + 1;
#endif // USE_GPS

Add flights counter to stats

66b2d7b

MrD-RC previously requested changes May 12, 2024

View reviewed changes

Switch flight count to use uint16

174e9d4

stronnag previously requested changes May 12, 2024

View reviewed changes

Update the stats' PG Template version

d93a128

TransientTetra requested a review from stronnag May 12, 2024 19:49

Add min distance check to flight counter in stats; update settings.md

e0bd68d

TransientTetra requested review from MrD-RC, OptimusTi and breadoven June 2, 2024 16:56

breadoven reviewed Jun 13, 2024

View reviewed changes

src/main/fc/stats.c Outdated Show resolved Hide resolved

Fix if statement formatting

96c1679

OptimusTi previously requested changes Jun 13, 2024

View reviewed changes

src/main/fc/stats.c Outdated Show resolved Hide resolved

Change MIN_FLIGHT_DISTANCE_M from 10 to 30 meters

f3de09f

Co-authored-by: OptimusTi <[email protected]>

sensei-hacker added Testing Required Ready to merge New Feature and removed Testing Required labels Oct 12, 2025

sensei-hacker merged commit de322c4 into iNavFlight:master Oct 13, 2025

qodo-code-review bot added the Review effort 2/5 label Oct 13, 2025

MrD-RC added this to the 9.0 milestone Oct 26, 2025

Conversation

TransientTetra commented May 11, 2024

Uh oh!

MrD-RC commented May 12, 2024

Uh oh!

MrD-RC commented May 12, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stronnag left a comment

Choose a reason for hiding this comment

Uh oh!

TransientTetra commented Jun 11, 2024

Uh oh!

Uh oh!

breadoven commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OptimusTi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TransientTetra commented Jul 6, 2024

Uh oh!

TransientTetra commented Jul 25, 2024

Uh oh!

sensei-hacker commented Oct 12, 2025

Uh oh!

sensei-hacker commented Oct 13, 2025

Uh oh!

qodo-code-review bot commented Oct 13, 2025

PR Reviewer Guide 🔍

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

breadoven commented Jun 13, 2024 •

edited

Loading