Accurately consider inactive displays when signaling child#3761
Closed
dfoxfranke wants to merge 1 commit intoi3:nextfrom
Closed
Accurately consider inactive displays when signaling child#3761dfoxfranke wants to merge 1 commit intoi3:nextfrom
dfoxfranke wants to merge 1 commit intoi3:nextfrom
Conversation
stapelberg
requested changes
Aug 9, 2019
Member
stapelberg
left a comment
stapelberg
left a comment
There was a problem hiding this comment.
Thanks for your PR! As I was looking at it anyway to reply on the issue, I figured I might as well leave a few review comments, even though it’s still in draft state.
| bool changed = params->outputs_walk->active != (bool)val; | ||
| if (changed) { | ||
| params->outputs_walk->active = val; | ||
| stop_or_cont_child(); |
Member
There was a problem hiding this comment.
Can you move this stop_or_cont_child call into i3bar/src/ipc.c:got_output_reply next to the reconfig_windows calls please? I think it’d be cleaner to modify state after parsing, not while parsing :)
|
|
||
| if (!strcmp(params->cur_key, "active")) { | ||
| params->outputs_walk->active = val; | ||
| bool changed = params->outputs_walk->active != (bool)val; |
Member
There was a problem hiding this comment.
nit: here and below, please:
- Mark these bools as const.
- Add parens around the expression.
| */ | ||
| void cont_child(void); | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
nit: use /** so that doxygen will pick up the comment.
Member
|
@dfoxfranke Are you planning on following up on this? :-) |
orestisfl
added a commit
to orestisfl/i3
that referenced
this pull request
Apr 8, 2020
Following the reproduction instructions from i3#3242 (comment) For me, i3#3242 happened when the following sequence executed: 1. Fullscreening window correctly calls `stop_child()` in https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L685 2. Xrandr change, `reconfig_windows()` is called and `output->visible` is set to `true` in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L1791 3. When the window's fullscreen is disabled, `handle_visibility_notify()` returns in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L677 because previously `output->visible` was set to `true` To fix this, I call `cont_child()` more leniently since it is a no-op when the child is not stopped. Fixes i3#3242 Closes i3#3761
stapelberg
pushed a commit
that referenced
this pull request
Apr 9, 2020
Following the reproduction instructions from #3242 (comment) For me, #3242 happened when the following sequence executed: 1. Fullscreening window correctly calls `stop_child()` in https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L685 2. Xrandr change, `reconfig_windows()` is called and `output->visible` is set to `true` in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L1791 3. When the window's fullscreen is disabled, `handle_visibility_notify()` returns in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L677 because previously `output->visible` was set to `true` To fix this, I call `cont_child()` more leniently since it is a no-op when the child is not stopped. Fixes #3242 Closes #3761
stapelberg
pushed a commit
that referenced
this pull request
Apr 22, 2020
Following the reproduction instructions from #3242 (comment) For me, #3242 happened when the following sequence executed: 1. Fullscreening window correctly calls `stop_child()` in https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L685 2. Xrandr change, `reconfig_windows()` is called and `output->visible` is set to `true` in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L1791 3. When the window's fullscreen is disabled, `handle_visibility_notify()` returns in this line: https://github.com/i3/i3/blob/6e24e2ad6f4b1e32cfa27805a3a948d0de50f3b1/i3bar/src/xcb.c#L677 because previously `output->visible` was set to `true` To fix this, I call `cont_child()` more leniently since it is a no-op when the child is not stopped. Fixes #3242 Closes #3761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #3242. Marked as draft because I haven't tested this yet.