-
-
Notifications
You must be signed in to change notification settings - Fork 680
Description
Seems for TypeScript users (in combination with react) it would be better to set the returnNull value to false by default.
i18next/react-i18next#1559
i18next/react-i18next#1576
i18next/react-i18next#1574
i18next/next-i18next#1795
i18next/next-i18next#2038
i18next/next-i18next#2059
https://stackoverflow.com/questions/70914886/react-i18n-t-function-doesnt-accept-string-variables-typescript-no-over/74817767
https://stackoverflow.com/questions/74146925/im-having-issues-with-i18next-in-react-18/74811575
https://stackoverflow.com/questions/74143213/how-to-handle-i18next-new-type-defaulttfuncreturn/74808715
Let's keep returnEmptyString set to true by default (not necessary regarding TypeScript issues)
I would say as soon as @pedrodurek reviewed (and maybe corrected/optimized) the latest TypeScript changes and issues, we'll go for a new major release that changes the defaults, this would maybe simplify the usage for TypeScript users.
TODO before next major release
- verify t function changes, especially regarding performance: v22.3.0...master
- check if those changes are ok for react-i18next
- also check if this was ok: Extend the
initmethod with a generic parameter for backend options #1878 - recheck https://github.com/i18next/react-i18next/issues?q=is%3Aissue+is%3Aopen+label%3Atypescript
- recheck https://github.com/i18next/i18next/issues?q=is%3Aissue+is%3Aopen+label%3Atypescript
- recheck https://github.com/i18next/next-i18next/issues?q=is%3Aissue+is%3Aopen+label%3Atypescript
- is there also a solution for https://github.com/i18next/next-13-app-dir-i18next-example-ts/blob/main/app/i18n/index.ts#L26 ?
TODO
- PR change returnNull default to false #1885
- merge PR change returnNull default to false #1885
- docs changes: https://www.i18next.com/overview/configuration-options#translation-defaults and https://www.i18next.com/overview/typescript
- also merge PR prefixed ordinal keys #1945 for next major
- maybe also consider Don't transpile to es5 #1948 for next major
- and if Don't transpile to es5 #1948 also remove the isIE stuff
- remove the setDebug function in the logger How to turn off or on debug logging dynamically - ¿possible bug? #1954 (comment)
