Fix is_front_page() not working on WC shop page set as site's static front page

marian-kadanka · marian-kadanka · commit 2dc44a136bbe · 2017-10-30T15:56:52.000+01:00
Not sure why this branch of IF conditional set post_type to 'product',
since post_type is not set when using WooCommerce shop page as site's
static front page. Removing this ELSE branch fix the issue and
everything else is working fine.

Tested with WooCommerce 3.1.2 and 3.2.1, switching default languages,
using both shop page as site's front page and on standalone shop
pages in all language versions.
diff --git a/src/Hyyan/WPI/Pages.php b/src/Hyyan/WPI/Pages.php
@@ -114,8 +114,6 @@ public function correctShopPage(\WP $wp) {
                     $wp->query_vars['post_type'] = 'product';
                 }
             }
-        } else {
-            $wp->query_vars['post_type'] = 'product';
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,6 @@ public function correctShopPage(\WP $wp) {`
`114`	`114`	`$wp->query_vars['post_type'] = 'product';`
`115`	`115`	`}`
`116`	`116`	`}`
`117`		`- } else {`
`118`		`- $wp->query_vars['post_type'] = 'product';`
`119`	`117`	`}`
`120`	`118`	`}`
`121`	`119`