improves #353 fix

Jon007 · Jon007 · commit 1d83ef23e96f · 2018-08-19T20:44:09.000+01:00
additional defensive code ensures wc_product_generate_unique_sku
doesn’t result in duplicate sku when called with no productid by
woocommerce product_duplicate
diff --git a/src/Hyyan/WPI/Product/Meta.php b/src/Hyyan/WPI/Product/Meta.php
@@ -820,6 +820,11 @@ public function suppressInvalidDuplicatedSKUErrorMsg($sku_found, $product_id, $s
 		if ( ! $sku_found ) {
 			return false;
 		}
+		//if called with no product id from woocommerce product_duplicate
+		//no further check can be done
+		if ( ! $product_id ) {
+			return $sku_found;
+		}
 
 		/*
 		 * now check the duplicates
@@ -842,6 +847,10 @@ public function suppressInvalidDuplicatedSKUErrorMsg($sku_found, $product_id, $s
 		)
 		);
 		$curlang = pll_get_post_language( $product_id );
+		if ( ! $curlang ) {
+			//if there is no language no further check can be done
+			return $sku_found;
+		}
 		foreach ( $postids as $post_id ) {
 			//suppress duplicate sku error on translations only
 			$duplang = pll_get_post_language( $post_id );
