stock enhancements - ignore missing translations

Jon007 · Jon007 · commit 08c9913105e6 · 2019-06-11T21:58:09.000+01:00
avoid errors logged when product is not translated
diff --git a/src/Hyyan/WPI/Product/Stock.php b/src/Hyyan/WPI/Product/Stock.php
@@ -78,11 +78,13 @@ public static function SyncStock( \WC_Product $product ) {
 			Variation::getRelatedVariation( get_post_meta( $product_with_stock->get_id(), Variation::DUPLICATE_KEY, true ), true ) :
 			Utilities::getProductTranslationsArrayByObject( $product_with_stock );
 
-			foreach ( $product_translations as $product_translation ) {
-				if ( $product_translation != $product_with_stock->get_id() ) {
-					$translation = wc_get_product( $product_translation );
-					if ( $translation ) {
-						wc_update_product_stock( $translation, $targetValue );
+			if ( $product_translations ) {
+				foreach ( $product_translations as $product_translation ) {
+					if ( $product_translation != $product_with_stock->get_id() ) {
+						$translation = wc_get_product( $product_translation );
+						if ( $translation ) {
+							wc_update_product_stock( $translation, $targetValue );
+						}
 					}
 				}
 			}
diff --git a/src/Hyyan/WPI/Product/Variation.php b/src/Hyyan/WPI/Product/Variation.php
@@ -109,6 +109,9 @@ public function duplicate()
     public static function getRelatedVariation($variatonID, $returnIDS = false)
     {
         $result = array();
+        if ( ! $variatonID ) {
+          return false;
+        }
 
         //previous version of code using get_post_meta() was filtered at runtime by Polylang
         //even when adding 'suppress_filters' => true, so there was no way to adjust stock

Original file line number	Diff line number	Diff line change
`@@ -78,11 +78,13 @@ public static function SyncStock( \WC_Product $product ) {`
`78`	`78`	`Variation::getRelatedVariation( get_post_meta( $product_with_stock->get_id(), Variation::DUPLICATE_KEY, true ), true ) :`
`79`	`79`	`Utilities::getProductTranslationsArrayByObject( $product_with_stock );`
`80`	`80`
`81`		`- foreach ( $product_translations as $product_translation ) {`
`82`		`- if ( $product_translation != $product_with_stock->get_id() ) {`
`83`		`- $translation = wc_get_product( $product_translation );`
`84`		`- if ( $translation ) {`
`85`		`- wc_update_product_stock( $translation, $targetValue );`
	`81`	`+ if ( $product_translations ) {`
	`82`	`+ foreach ( $product_translations as $product_translation ) {`
	`83`	`+ if ( $product_translation != $product_with_stock->get_id() ) {`
	`84`	`+ $translation = wc_get_product( $product_translation );`
	`85`	`+ if ( $translation ) {`
	`86`	`+ wc_update_product_stock( $translation, $targetValue );`
	`87`	`+ }`
`86`	`88`	`}`
`87`	`89`	`}`
`88`	`90`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,6 +109,9 @@ public function duplicate()`
`109`	`109`	`public static function getRelatedVariation($variatonID, $returnIDS = false)`
`110`	`110`	`{`
`111`	`111`	`$result = array();`
	`112`	`+ if ( ! $variatonID ) {`
	`113`	`+ return false;`
	`114`	`+ }`
`112`	`115`
`113`	`116`	`//previous version of code using get_post_meta() was filtered at runtime by Polylang`
`114`	`117`	`//even when adding 'suppress_filters' => true, so there was no way to adjust stock`