Skip to content

Comments

fix(tonic): depend on http at least 1.1.0#2426

Merged
tottoto merged 2 commits intohyperium:masterfrom
bobrik:ivan/tonic-http-1.1
Oct 16, 2025
Merged

fix(tonic): depend on http at least 1.1.0#2426
tottoto merged 2 commits intohyperium:masterfrom
bobrik:ivan/tonic-http-1.1

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Oct 15, 2025

We use try_insert, which was added in v1.1.0:

error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
--> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |

We use `try_insert`, which was added in v1.1.0:

* hyperium/http#682

```
error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
  --> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |
```
@tottoto tottoto enabled auto-merge (squash) October 16, 2025 12:55
@tottoto tottoto merged commit a4e6fb5 into hyperium:master Oct 16, 2025
20 checks passed
alexanderrilee pushed a commit to alexanderrilee/tonic that referenced this pull request Oct 29, 2025
We use `try_insert`, which was added in v1.1.0:

* hyperium/http#682

```
error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
--> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |
```

Co-authored-by: tottoto <[email protected]>
jen20 pushed a commit to jen20/tonic that referenced this pull request Dec 30, 2025
We use `try_insert`, which was added in v1.1.0:

* hyperium/http#682

```
error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
--> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |
```

Co-authored-by: tottoto <[email protected]>
LucioFranco added a commit that referenced this pull request Jan 28, 2026
# Changelog for v0.14.3

## Features

- Expose `tcp_keepalive_interval` and `tcp_keepalive_retries` options on
Server (#2472)
- Allow configuration of `max_local_error_reset_streams` on Server
(#2437)
- Put source error into the `Display` impl of `Status` (#2417)
- `Server::default()` now sets `TCP_NODELAY` to true (#2413)

## Bug Fixes

- Respect `max_message_size` when decompressing a message (#2484)
- Depend on http at least 1.1.0 (#2426)

## Documentation

- Fix documentation links for timeout configuration (#2483)
- Fix documentation typos and grammar issues in status.rs and
codec/mod.rs (#2468)
- Fix labels in `Display for Status` (#2414)
- Fix features docs in tonic-build and tonic-prost-build (#2434)
- Remove redundant word in tonic-build and tonic-prost-build README
(#2425)
grembo pushed a commit to grembo/tonic that referenced this pull request Feb 3, 2026
We use `try_insert`, which was added in v1.1.0:

* hyperium/http#682

```
error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
--> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |
```

Co-authored-by: tottoto <[email protected]>
LucioFranco pushed a commit that referenced this pull request Feb 13, 2026
We use `try_insert`, which was added in v1.1.0:

* hyperium/http#682

```
error[E0599]: no method named `try_insert` found for mutable reference `&mut HeaderMap` in the current scope
--> tonic/src/transport/channel/service/user_agent.rs:44:14
   |
42 |           if let Ok(Some(user_agent)) = req
   |  _______________________________________-
43 | |             .headers_mut()
44 | |             .try_insert(USER_AGENT, self.user_agent.clone())
   | |_____________-^^^^^^^^^^
   |
help: there is a method `insert` with a similar name
   |
44 -             .try_insert(USER_AGENT, self.user_agent.clone())
44 +             .insert(USER_AGENT, self.user_agent.clone())
   |
```

Co-authored-by: tottoto <[email protected]>
LucioFranco added a commit that referenced this pull request Feb 13, 2026
- Expose `tcp_keepalive_interval` and `tcp_keepalive_retries` options on
Server (#2472)
- Allow configuration of `max_local_error_reset_streams` on Server
(#2437)
- Put source error into the `Display` impl of `Status` (#2417)
- `Server::default()` now sets `TCP_NODELAY` to true (#2413)

- Respect `max_message_size` when decompressing a message (#2484)
- Depend on http at least 1.1.0 (#2426)

- Fix documentation links for timeout configuration (#2483)
- Fix documentation typos and grammar issues in status.rs and
codec/mod.rs (#2468)
- Fix labels in `Display for Status` (#2414)
- Fix features docs in tonic-build and tonic-prost-build (#2434)
- Remove redundant word in tonic-build and tonic-prost-build README
(#2425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants