chore: relax msrv for most crates#2378
Merged
tottoto merged 3 commits intohyperium:masterfrom Aug 7, 2025
Merged
Conversation
dfawley
reviewed
Aug 6, 2025
|
|
||
| ### Rust Version | ||
|
|
||
| `tonic`'s MSRV is `1.75`. |
Collaborator
There was a problem hiding this comment.
Is there any reason not to go back to 1.75?
Collaborator
There was a problem hiding this comment.
Sorry I didn't see the initial comment in the PR.
Does protobuf-codegen need to affect the main tonic crates?
Contributor
Author
There was a problem hiding this comment.
No, it doesn't! I assumed all tonic-* crates required the same MSRV, but tonic-protobuf* are even marked as publish = false. I excluded them as well from the MSRV check in the CI.
A small code change was needed to work with 1.75 because we cannot rely on the automatic lifetime extension of temporaries.
Collaborator
There was a problem hiding this comment.
That's great, thank you for the fix!
tottoto
approved these changes
Aug 7, 2025
Member
|
Thanks for getting this solved! |
Contributor
|
Thanks! |
cjqzhao
pushed a commit
to cjqzhao/tonic
that referenced
this pull request
Aug 7, 2025
* chore: relax msrv for most crates * Keep MSRV 1.75 * Allow to compile with 1.75 again
cjqzhao
pushed a commit
to cjqzhao/tonic
that referenced
this pull request
Aug 7, 2025
* chore: relax msrv for most crates * Keep MSRV 1.75 * Allow to compile with 1.75 again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2361
Solution
Relax version of the workspace to 1.75
1.82, specify msrv forgrpccrate as 1.86.Exclude
grpcandtonic-protobuf*from msrv check. They require a higher msrv and they do not specifyrust-version = { workspace = true }.A small code change is needed because we cannot rely on automatic lifetime extension of temporaries.
Without thegrpccrate we would need to bump only to 1.79 because ofprotobuf-codegen v4.31.1-release.Withgrpcwe need 1.82 because oficu_*crates.We could move grpc to another workspace to avoid bumping the tonic to 1.82, but I don't think is worth it.