feat(prost-build): Add service_generator method to Builder#2364
Merged
LucioFranco merged 1 commit intohyperium:masterfrom Aug 1, 2025
Merged
feat(prost-build): Add service_generator method to Builder#2364LucioFranco merged 1 commit intohyperium:masterfrom
service_generator method to Builder#2364LucioFranco merged 1 commit intohyperium:masterfrom
Conversation
This adds back the `service_generator` method to the `tonic_prost_build::Builder`, which allows retrieving the `prost_build::ServiceGenerator` implementation. This was present in Tonic v0.13, so this just adds back the method.
LucioFranco
approved these changes
Aug 1, 2025
cjqzhao
pushed a commit
to cjqzhao/tonic
that referenced
this pull request
Aug 7, 2025
cjqzhao
pushed a commit
to cjqzhao/tonic
that referenced
this pull request
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tonic v0.13 had a
service_generatormethod ontonic_build::Builder, which allowed retrieving theprost_build::ServiceGeneratorimplementation for more advanced customization. This method was removed in v0.14, but would still be useful to have intonic_prost_build.Solution
This adds back the
service_generatormethod totonic_prost_build::Builder. The previous implementation ofservice_generatoris here.I've also removed the
out_dirfield from theBuilderstruct since this was not used and would require theservice_generatormethod definition to differ from v0.13.I've duplicated the
ServiceGenerator::newcall since this was already duplicated betweencompile_with_configandcompile_fds_with_config. Instead of duplicating theServiceGenerator::newcall, should I change the other calls fromServiceGenerator::newtoself.service_generator()?