examples: switch version to last released version#2047
Merged
LucioFranco merged 2 commits intohyperium:masterfrom Nov 14, 2024
Merged
examples: switch version to last released version#2047LucioFranco merged 2 commits intohyperium:masterfrom
LucioFranco merged 2 commits intohyperium:masterfrom
Conversation
As part of hyperium#2014, the versions of "tonic" and "tonic-build" were changed to "0.13". This breaks the instuctions in the examples documentation with an error like: ``` helloworld_tonic$ cargo run --bin helloworld-server Updating crates.io index error: failed to select a version for the requirement `tonic = "^0.13"` candidate versions found which didn't match: 0.12.3, 0.12.2, 0.12.1, ... location searched: crates.io index required by package `helloworld-tonic v0.1.0 (/usr/local/google/home/easwars/src/rust/projects/helloworld_tonic)` if you are looking for the prerelease package it needs to be specified explicitly tonic = { version = "0.1.0-beta.1" } ``` This PR changes the version of "tonic" and "tonic-build" to "*" which results in the latest version getting picked. Setting it to "*" also has the nice property of not having to update the examples everytime a version bump is required.
LucioFranco
approved these changes
Nov 13, 2024
Member
LucioFranco
left a comment
LucioFranco
left a comment
There was a problem hiding this comment.
CI failure is unrelated, ill take a look at it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As part of #2014, the versions of "tonic" and "tonic-build" were changed to
0.13. This breaks the instuctions in the examples documentation with an error like:Solution
This PR changes the version of "tonic" and "tonic-build" to
*which results in the latest version getting picked. Setting it to*also has the nice property of not having to update the examples everytime a version bump is required.