docs(tonic-build): try to improve the doc-diff between tonic-build's lib.rs and Readme#2035
Closed
CommanderStorm wants to merge 1 commit intohyperium:masterfrom
Closed
docs(tonic-build): try to improve the doc-diff between tonic-build's lib.rs and Readme#2035CommanderStorm wants to merge 1 commit intohyperium:masterfrom
tonic-build's lib.rs and Readme#2035CommanderStorm wants to merge 1 commit intohyperium:masterfrom
Conversation
…` and the readme
CommanderStorm
force-pushed
the
tonic-build
branch
from
65f1627 to
e4a8973
Compare
Contributor
Author
|
Not quite happy with the ginormous google example being in the docs at this place. |
Member
|
@CommanderStorm are you still interested in pushing this change through? If so feel free to reopen the PR and we can get some of this reviewed and merged. |
Contributor
Author
Shure. have opened #2308 for the docs change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I had a bit of a hard time figuring out the getting started guide.
This PR tries to improve a bit on these shortcomings:
Solution
lib.rsand Readme to avoid getting to the same place in a few months