chore: Start development of version 0.13#2014
Merged
tobz merged 1 commit intohyperium:masterfrom Oct 22, 2024
Merged
Conversation
tottoto
force-pushed
the
start-development-of-version-0.13
branch
from
88de84d to
e4d4840
Compare
Collaborator
Author
|
I opened this pull request as I think we probably could start development of the next version including breaking changes as @LucioFranco merged #1892 which includes breaking changes. This change is needed for the pull requests such as #2006 and #2013. |
djc
approved these changes
Oct 18, 2024
LucioFranco
requested changes
Oct 18, 2024
Member
LucioFranco
left a comment
LucioFranco
left a comment
There was a problem hiding this comment.
LGTM just want to change the version to not include dev, thanks.
tonic-build/Cargo.toml
Outdated
| readme = "README.md" | ||
| repository = "https://github.com/hyperium/tonic" | ||
| version = "0.12.3" | ||
| version = "0.13.0-dev" |
Member
There was a problem hiding this comment.
Can we just make the version 0.13.0 and not add the dev portion?
Collaborator
Author
There was a problem hiding this comment.
Updated to 0.13.0.
tottoto
force-pushed
the
start-development-of-version-0.13
branch
from
e4d4840 to
c147b85
Compare
tottoto
force-pushed
the
start-development-of-version-0.13
branch
from
c147b85 to
274cde8
Compare
shikhar
added a commit
to shikhar/tonic
that referenced
this pull request
Nov 6, 2024
This reverts commit 3009cf5.
easwars
added a commit
to easwars/tonic
that referenced
this pull request
Nov 13, 2024
As part of hyperium#2014, the versions of "tonic" and "tonic-build" were changed to "0.13". This breaks the instuctions in the examples documentation with an error like: ``` helloworld_tonic$ cargo run --bin helloworld-server Updating crates.io index error: failed to select a version for the requirement `tonic = "^0.13"` candidate versions found which didn't match: 0.12.3, 0.12.2, 0.12.1, ... location searched: crates.io index required by package `helloworld-tonic v0.1.0 (/usr/local/google/home/easwars/src/rust/projects/helloworld_tonic)` if you are looking for the prerelease package it needs to be specified explicitly tonic = { version = "0.1.0-beta.1" } ``` This PR changes the version of "tonic" and "tonic-build" to "*" which results in the latest version getting picked. Setting it to "*" also has the nice property of not having to update the examples everytime a version bump is required.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
As part of #2014, the versions of "tonic" and "tonic-build" were changed to "0.13". This breaks the instuctions in the examples documentation with an error like: ``` helloworld_tonic$ cargo run --bin helloworld-server Updating crates.io index error: failed to select a version for the requirement `tonic = "^0.13"` candidate versions found which didn't match: 0.12.3, 0.12.2, 0.12.1, ... location searched: crates.io index required by package `helloworld-tonic v0.1.0 (/usr/local/google/home/easwars/src/rust/projects/helloworld_tonic)` if you are looking for the prerelease package it needs to be specified explicitly tonic = { version = "0.1.0-beta.1" } ``` This PR changes the version of "tonic" and "tonic-build" to "*" which results in the latest version getting picked. Setting it to "*" also has the nice property of not having to update the examples everytime a version bump is required. Co-authored-by: Lucio Franco <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Starts the development of version 0.13. This is needed to tell
cargo-semver-checksthat the development includes breaking changes.Solution
Updates versions to
0.13.0-dev.