fix(tls): do not shutdown server on broken connections#1948
Merged
LucioFranco merged 1 commit intohyperium:masterfrom Sep 20, 2024
Merged
fix(tls): do not shutdown server on broken connections#1948LucioFranco merged 1 commit intohyperium:masterfrom
LucioFranco merged 1 commit intohyperium:masterfrom
Conversation
djc
approved these changes
Sep 20, 2024
Contributor
|
Makes sense, thanks! |
LucioFranco
approved these changes
Sep 20, 2024
This was referenced Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a continuation of #1938. Other errors are not fatal to the server as a whole.
I observed this today in production (we are already running #1938). While connections breaking are much less rare than "unexpected eof", they still happened once:
Solution
The solution is to add "connection reset" and "broken pipe" errors to the list of non-fatal errors that make the accept loop continue.