fix(tonic-build): cargo build script outputs are not functional#1821
Merged
djc merged 1 commit intohyperium:masterfrom Jul 25, 2024
Merged
fix(tonic-build): cargo build script outputs are not functional#1821djc merged 1 commit intohyperium:masterfrom
djc merged 1 commit intohyperium:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I was looking through and debugging some services and noticed that the
println!()statements in thetonic-buildcrate were not correctly formatted.Example 1:
tonic/tonic-build/src/prost.rs
Line 651 in 255a885
Example 2:
tonic/tonic-build/src/prost.rs
Line 658 in 255a885
They all have a single
:when they should have 2 as shown in the cargo book:https://doc.rust-lang.org/cargo/reference/build-scripts.html#rerun-if-changed
Solution
Just added the extra
:, did a full workspace search to ensure I got all of them 👍If there's anything else you'd like me to do to properly follow any requirements please let met know 😄