feat(tls): Add ability to add multiple ca certificates#1724
feat(tls): Add ability to add multiple ca certificates#1724djc merged 2 commits intohyperium:masterfrom
Conversation
tottoto
force-pushed
the
multiple-ca-certificates
branch
4 times, most recently
from
bd66035 to
c3f9ae5
Compare
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Is the next step here to get rid of the Certificate abstraction around CertificateDer<'_>? Would be nice!
|
I would think that |
|
Well, the caller would rely on rustls-pemfile so it's one less mandatory dependency to carry within tonic. |
|
Considering |
|
Added a method to add multiple ca certificates at once, which is useful when having some sets of certificates. |
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
8781f15 to
9e76a66
Compare
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
9e76a66 to
0837c0b
Compare
tonic/src/transport/channel/tls.rs
Outdated
| } | ||
|
|
||
| /// Sets the multiple CA Certificates against which to verify the server's TLS certificate. | ||
| pub fn ca_certificates(self, ca_certificates: Vec<Certificate>) -> Self { |
There was a problem hiding this comment.
Let's take an impl IntoIterator<Item = Certificate> here, instead?
There was a problem hiding this comment.
Sounds good to me. Updated to use it.
tottoto
force-pushed
the
multiple-ca-certificates
branch
from
0837c0b to
2c3ebee
Compare
2 participants
Resolves #1629.