feat: port legacy client integration tests#77
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Dec 25, 2023
Merged
Conversation
dswij
force-pushed
the
port-legacy-client-test
branch
from
ea43cea to
2b0fd1b
Compare
Member
Author
|
@seanmonstar would you prefer if all the tests are ported in one huge PR, or split up into multiple smaller PRs? |
Member
|
Either is fine to me. I have no problem merging in chunks, or if it's easier we can wait. |
dswij
force-pushed
the
port-legacy-client-test
branch
2 times, most recently
from
65d8bdb to
5f00a5e
Compare
dswij
force-pushed
the
port-legacy-client-test
branch
from
5f00a5e to
d5347c7
Compare
Member
Author
|
@seanmonstar This is ready for review. I skipped the test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of hyperium/hyper#2942