feat: add {http1,http2}_only for auto conn#111
Merged
seanmonstar merged 1 commit intohyperium:masterfrom May 24, 2024
Merged
Conversation
dswij
force-pushed
the
issue-3511
branch
3 times, most recently
from
b29fc46 to
a5f37b7
Compare
Member
|
@sfackler would this solve your use case? |
17 tasks
cxw620
reviewed
Apr 1, 2024
tisonkun
approved these changes
May 5, 2024
Contributor
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Share my opinion on the style issue. In general, I'm OK with either way and let's try to move forward.
Contributor
|
Hey. Just wanted to check in to see if there's anything that I can do to help push this forward? |
seanmonstar
approved these changes
May 18, 2024
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Thanks dswij! Can be merged after conflicts are resolved.
Contributor
|
@seanmonstar I send a follow-up to resolve the conflict at #124. It retains @dswij's credit. Hopefully we can move forward and my major target is to help hyperium/tonic#1670 done. |
Contributor
|
@seanmonstar This patch has some uncompleted part. I fix it up at 582cd9f and you can review #124. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes hyperium/hyper#3511
This PR adds an option to choose http1 or http2 only for auto connections.